From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E8E4A0579; Fri, 9 Apr 2021 15:41:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0774140FCB; Fri, 9 Apr 2021 15:41:25 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A3C0C4014D for ; Fri, 9 Apr 2021 15:41:23 +0200 (CEST) IronPort-SDR: dBeisE4Jmg32W+QttGTZRoJRYZdsJHnKID57QLgwy20rjao7zQDh6eT2gDC3bTR2mrgfNA+SGT lFWyEaKohV5A== X-IronPort-AV: E=McAfee;i="6000,8403,9949"; a="193802507" X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="193802507" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 06:41:22 -0700 IronPort-SDR: KsIebjsVGPUjq8d/pNHb2sOJjWl5FbIyofFqIAJuYlh31SQDScDhZfT3THGQWPolwDpFVM39K8 o0oLmngGqM0g== X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="459237120" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.224]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Apr 2021 06:41:19 -0700 Date: Fri, 9 Apr 2021 14:41:11 +0100 From: Bruce Richardson To: David Marchand Cc: dev , Aaron Conole Message-ID: <20210409134111.GB1381@bricha3-MOBL.ger.corp.intel.com> References: <20210127174255.1671738-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] test: allow taking test names from commandline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 09, 2021 at 03:27:17PM +0200, David Marchand wrote: > On Wed, Jan 27, 2021 at 6:43 PM Bruce Richardson > wrote: > > > > While having the ability to run a test based off the DPDK_TEST environment > > variable is useful, it's often easier to specify the test name as a > > commandline parameter to a test binary. This also allows the test runs to > > be saved as part of the shell cmdline history. > > I don't get the argument about history: > > $ history |grep DPDK_TEST > 10615 2021-03-24 10:42:11 ninja-build -C build -j4 && > DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 > --log-level=lib.eal:debug > 10636 2021-03-24 10:51:09 ninja-build -C build -j4 && > DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 > --log-level=lib.eal:debug > 10653 2021-03-24 11:17:01 ninja-build -C build -j4 && > DPDK_TEST=kvargs_autotest ./build/app/test/dpdk-test --no-huge -m 512 > --log-level=lib.eal:debug > 10794 2021-03-25 18:37:48 history |grep DPDK_TEST > Sure, if you always specify the test name explicitly for each command, rather than running the one test multiple times having set it separately in the environment. Overall, though I take the point that from a history saving point of view it's a minor saving. > > > > > This patch adds support for checking all parameters after the EAL ones, and > > running all valid autotests requested - either from DPDK_TEST or on the > > commandline. This also allows multiple tests to be run in a single > > automated session, which is useful for working with components which have > > multiple test suites. > > The same could be achieved splitting DPDK_TEST content with spaces, > since test names don't contain one. > Yep, that's a useful enhancement too, but I still thing it's better to just have the list of tests appended to the test binary command rather than have to be worrying about properly quoting a specific environment variable at the start of each command. /Bruce