From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5BA7A0C44; Mon, 12 Apr 2021 12:03:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41A9D141087; Mon, 12 Apr 2021 12:03:32 +0200 (CEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id BED8C141086; Mon, 12 Apr 2021 12:03:30 +0200 (CEST) Received: by mail-lf1-f44.google.com with SMTP id n8so20480601lfh.1; Mon, 12 Apr 2021 03:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BGmXqW4Fk1jX5SIVTaZjc+ljxavnV1QPRT+4Qfe2mWo=; b=gdlMJPRY+PNf4Vdxk2NodpUtxOCN9SpjjMbvB4tv122eVboC6gLnlM2keqLFj4FKZp ZpDqIf4v5Pa/Fek8RDUXJfDzNjpTOrGvsM16pib0cEnAhmMtcHSxapdlaI0Yzwczg0VZ 0wULHkFlz2ESIgRZv5IXzmg0q6qhjX913Y/thh6syX3wSruQPGSGyAfCCYma9tBDqUA1 k4J+auh0VgEu38gtXyIaBy5Q1WikyrsSE6lTBVzpYdNL9AJNv0vaeNOks01zGp+29f6d jQ+mgSrCbsNUqXF6/iSiI0dZsIpYD30ol7vOBK1A1u8+WSrmDDYdlByuJX73c8i1JLES lgAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BGmXqW4Fk1jX5SIVTaZjc+ljxavnV1QPRT+4Qfe2mWo=; b=EZtrZjKcttnwq6QSottyhwmc7+EuLJF0YAhC9Hh+lSMKT75cL4TET7iv+7cz/F1Qg6 Pyc/+02bR4xbzXn6hQQxcBskDdpwIj0NhoxzfFhtbUUKgHleYEqQC7vgqVwvYN22M6fY cZy2Zhfp+x2XpINLPaUHO2Y9GRmGquZGlKWJOCEtV5uVMq1mM7DeQTOzoxuIPwW2TuAh O0vEOjp1YL6r2IWQO2FthmfWMdbOl8gxtczGTpg7lewgJpT/byqclTdhv6Q6eohkaWzZ KGxhoDhcCcvLCN5VHYLxplDJcYypXJ540qxXUD+ZlAgp0HDPPZUdTepMHl3aJq+3/yDS sy0A== X-Gm-Message-State: AOAM532fGVsnGbT1TEggm4ZEetsqTwAXZBOABZ9VQImbKQxLKjHjeNAv F7+/9u/7FMwyyNbWIFE5AzQ= X-Google-Smtp-Source: ABdhPJxA2gfTM4qj/T7iiGf6KOtvgNVI+4zGl/aYF9eD9A6F+RRWIaZXKp92eamGciV4BSH8PBo6Lw== X-Received: by 2002:ac2:51a3:: with SMTP id f3mr5501896lfk.571.1618221810135; Mon, 12 Apr 2021 03:03:30 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id d15sm1361178lfm.247.2021.04.12.03.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 03:03:29 -0700 (PDT) Date: Mon, 12 Apr 2021 13:03:28 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "david.marchand@redhat.com" , "lucp.at.work@gmail.com" , "stable@dpdk.org" Message-ID: <20210412130328.5a7b1db0@sovereign> In-Reply-To: References: <20210410195433.13416-1-talshn@nvidia.com> <20210412000035.77a1f0f6@sovereign> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-12 07:59 (UTC+0000), Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > >=20 > > External email: Use caution opening links or attachments > >=20 > >=20 > > Hi Tal, > >=20 > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > >=20 > > ../../../lib/librte_eal/common/eal_common_thread.c: In function > > =E2=80=98ctrl_params_free=E2=80=99: > > ../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value > > computed is not used [-Wunused-value] > > 42 | !DeleteSynchronizationBarrier(barrier) > >=20 > > Probably applies to other functions and may fire in combination with fu= ture > > backported patches. Hopefully since 21.05 there will be new threading A= PI. =20 >=20 > Thanks Dmitry, it's odd that the compiler complains only now, I'd expect = to see this warning even before the change. These functions don't have "nodiscard"-like attributes, so a call without using result was OK, now it's an expression. > Do we know if the new threading API will be in 21.05? API changes close i= n 3 days and I didn't see it get reviewed/acked. > I can change only pthread_barrier_init for now, since currently without t= his change Windows runtime is broken, what do you think?=20 (You probably mean pthread_barrier_destroy(), from which the warning comes.) Yes, this is worth merging as soon as warnings are fixed. Not sure new threading API will make it into 21.05.