From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D04A0524; Tue, 13 Apr 2021 09:00:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7575160B95; Tue, 13 Apr 2021 09:00:10 +0200 (CEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id 6DEB316074D for ; Tue, 13 Apr 2021 09:00:09 +0200 (CEST) Received: by mail-lf1-f41.google.com with SMTP id f41so2226656lfv.8 for ; Tue, 13 Apr 2021 00:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0dT1ZOIIG0s+puZobJcBL2YVj7e4RZ862stGWWIhyHo=; b=kWRkYttdXuO6VUgTDPs6pt5WBjrxYUvaFA1mO2UiKRLrfWKxoQWVfuqM4N8wm0gf/M yU3vyyfzKyyC5BRgVXuYuuGhL7ZAyKKuYjPz3NeGH+OIVCxlwhcVFHJSgvJau+SV6FWD skcsNoqpnjZbfsj+wMdj8tDaXTvOZsCgNFdbMiJG5dB3HBxRTKDPuIGKI+yWr8yoQ3mO cd0JsrArDAOL0dGsbg1dGlNV0CK4BoaKaKtkIgrtE5r3fhSXQvw1zWhgRo6vZI7hKPx1 FKYMdRQ58Ta5PAyqJNbC8+4IEbv8OA+qy9YCPTOsYRDBS+NIghtIRyhi79szAFDqKtyI /MJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0dT1ZOIIG0s+puZobJcBL2YVj7e4RZ862stGWWIhyHo=; b=bPpo77qug5ndUAfPtRDOgJjCfNevHFJ/enQ7HYFI26ABjl6MRXGOlEcPdjd5+wYmbz LY9o9udq5iziSb5LVZ1JHiwPn1H57WY26uNf+LKjPi0oY4+dPAjQUO2zFGXqPsmL0gsK OrrD4aw7K4eV5o6UcA7WUjFpgaoGmgUKXYtyUtInkF2zPXSTgO/zvAyW3k6DDPINfckD USeqFiCAa/f20cuJF8EFZgnTHrwqneuLoLdY8d0ARhW0sofdqj2seRk+nUQAfzNKziec HzF8iqYKJjgZH+9FCwRYGRcfGidntkCdz5exxVyQzhzsqyxYuuLIvFlRdj+8uXcOpkcR GiKw== X-Gm-Message-State: AOAM531lY2apVnBnLA6j2hoXuhnRMqvkBxt2rrKMTvPnHoqtLNQ+tu6N V4g3EexCFCdPaqVk8qU34kw= X-Google-Smtp-Source: ABdhPJw2Or7GfQ3R0QwAY0PK7KwDUgLIFClE/X/z5kYJoYTuF7a5k0Uqa7GH4MuWsiWNBhJCU+b00g== X-Received: by 2002:a19:4851:: with SMTP id v78mr10815629lfa.93.1618297208929; Tue, 13 Apr 2021 00:00:08 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id 3sm3036695lfq.1.2021.04.13.00.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 00:00:08 -0700 (PDT) Date: Tue, 13 Apr 2021 10:00:06 +0300 From: Dmitry Kozlyuk To: Ranjit Menon Cc: dev@dpdk.org Message-ID: <20210413100006.241c42fb@sovereign> In-Reply-To: <138b06d2-ab7e-704e-5f9f-d369f2490b45@intel.com> References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <20210410224732.20234-1-dmitry.kozliuk@gmail.com> <138b06d2-ab7e-704e-5f9f-d369f2490b45@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] > The change to remove the networking shim breaks l2fwd compilation on > Windows, since l2fwd/main.c includes netinet/in.h explicitly. > > How do you propose we fix this, only for Windows? This include is redundant for this file on all platforms, it can be removed. Since -Dexamples=all doesn't work on Windows because of missing dependencies, I wonder which of them need fixing.