From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DE39A0524; Tue, 13 Apr 2021 18:49:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C5F91611A7; Tue, 13 Apr 2021 18:49:14 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EE4B81611A5 for ; Tue, 13 Apr 2021 18:49:12 +0200 (CEST) IronPort-SDR: kC9E+FsvHzp4LCjn5Ur3vAO7FPdbep+hVmyU1n7Qt2GUSGa54pWggt/V3yGqxve5LG6Qg5mlmV /xySpsdGKOuA== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="192330403" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="192330403" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 09:48:45 -0700 IronPort-SDR: flcSZFiuPd/OcfBFqnXzb6NdJ0U6gfpsaWcC19q6zCWT2d4gSg/iUrL1D4740SVzcbEVfn1U+3 LJngmbg+AJig== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="460648132" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.6.19]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Apr 2021 09:48:42 -0700 Date: Tue, 13 Apr 2021 17:48:37 +0100 From: Bruce Richardson To: David Marchand Cc: dev , Aaron Conole Message-ID: <20210413164837.GB1185@bricha3-MOBL.ger.corp.intel.com> References: <20210127174255.1671738-1-bruce.richardson@intel.com> <20210409134111.GB1381@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409134111.GB1381@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH] test: allow taking test names from commandline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 09, 2021 at 02:41:11PM +0100, Bruce Richardson wrote: > On Fri, Apr 09, 2021 at 03:27:17PM +0200, David Marchand wrote: > > On Wed, Jan 27, 2021 at 6:43 PM Bruce Richardson > > wrote: > > > > > > While having the ability to run a test based off the DPDK_TEST environment > > > variable is useful, it's often easier to specify the test name as a > > > commandline parameter to a test binary. This also allows the test runs to > > > be saved as part of the shell cmdline history. > > > > I don't get the argument about history: > > > > $ history |grep DPDK_TEST > > 10615 2021-03-24 10:42:11 ninja-build -C build -j4 && > > DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 > > --log-level=lib.eal:debug > > 10636 2021-03-24 10:51:09 ninja-build -C build -j4 && > > DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 > > --log-level=lib.eal:debug > > 10653 2021-03-24 11:17:01 ninja-build -C build -j4 && > > DPDK_TEST=kvargs_autotest ./build/app/test/dpdk-test --no-huge -m 512 > > --log-level=lib.eal:debug > > 10794 2021-03-25 18:37:48 history |grep DPDK_TEST > > > > Sure, if you always specify the test name explicitly for each command, > rather than running the one test multiple times having set it separately in > the environment. > Overall, though I take the point that from a history saving point of view > it's a minor saving. > > > > > > > > > This patch adds support for checking all parameters after the EAL ones, and > > > running all valid autotests requested - either from DPDK_TEST or on the > > > commandline. This also allows multiple tests to be run in a single > > > automated session, which is useful for working with components which have > > > multiple test suites. > > > > The same could be achieved splitting DPDK_TEST content with spaces, > > since test names don't contain one. > > > > Yep, that's a useful enhancement too, but I still thing it's better to just > have the list of tests appended to the test binary command rather than have > to be worrying about properly quoting a specific environment variable at > the start of each command. > Ping on this. Other instances where using cmdline is preferred over environment * Calling tests using sudo. * Calling tests as an execute action when doing a git rebase Yes, again in both cases, other workarounds are generally available (e.g. sudo -E, and exporting to environemtn before rebase), but also generally less convenient. /Bruce