From: <pbhagavatula@marvell.com>
To: <david.marchand@redhat.com>, <jerinj@marvell.com>,
Jay Jayatheerthan <jay.jayatheerthan@intel.com>
Cc: <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: [dpdk-dev] [PATCH] eventdev: fix signed comparison
Date: Wed, 14 Apr 2021 03:46:12 +0530 [thread overview]
Message-ID: <20210413221613.2062-1-pbhagavatula@marvell.com> (raw)
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Since queue identifier is passed as signed integer, a compilation error
is generated:
rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type
in conditional expression [-Werror=sign-compare]
Make queue identifier as unsigned when adding it to vector data.
Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index e273b3acf..ca166a65f 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -1790,7 +1790,7 @@ rxa_update_queue(struct rte_event_eth_rx_adapter *rx_adapter,
static void
rxa_set_vector_data(struct eth_rx_queue_info *queue_info, uint16_t vector_count,
- uint64_t vector_ns, struct rte_mempool *mp, int32_t qid,
+ uint64_t vector_ns, struct rte_mempool *mp, uint32_t qid,
uint16_t port_id)
{
#define NSEC2TICK(__ns, __freq) (((__ns) * (__freq)) / 1E9)
--
2.17.1
next reply other threads:[~2021-04-13 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 22:16 pbhagavatula [this message]
2021-04-14 6:26 ` David Marchand
2021-04-14 6:52 ` Jerin Jacob
2021-04-14 8:06 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413221613.2062-1-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).