From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 04ED9A0562;
Wed, 14 Apr 2021 14:59:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E18C3161A91;
Wed, 14 Apr 2021 14:59:46 +0200 (CEST)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12on2085.outbound.protection.outlook.com [40.107.244.85])
by mails.dpdk.org (Postfix) with ESMTP id 5EB464013F
for <dev@dpdk.org>; Wed, 14 Apr 2021 14:59:45 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=ZC4jDIxNqnBcCPJkHic9jyqWvanjVWRDJw5ZTPWV5lxS6Tn+puxdZyc/D+qs4ith2qaDdeg7N0g6JIxK4pGoJQ74rPIjFA1ShgNnfQKXJP0aKjCNBVtqjUnokbpePof6c+njY4Lilt2ZDKKh3Rt5piJ062mOQMkHmEyREy3lB/up3ED/yUec93PfWikbO6GDyp0q9svb5pHH8gIo3v/F0qONKZvFoHp/Wvr3kb7ToFYHgGcc91uK9NoPI5TDKKMoW+KGXgYrn/ly3vrjJtunODHhelBGjtyOfP/0OpekB0odRdsMHkPJfsKi/YC7AhzLl5fuZ2Fs/sGQFsYVirxGNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=FvXz5NWI86nJTupERLesvQWZbUhq8jqlMlFptAMIJ0M=;
b=PL81d3dD/fuvp1Z2VYbF+01GPKlp0wr5qZlUlZW9YtL2zgzVJCx9jaoYSM07xG4+oE//tOKYfg3bJLFuOt6rgQ6mpsilNV3Vv3xpmiVeOMU7mkklYHSpAuRwXV8/Ynhz7xuWeCr1/szSmuM7jtLAiLRDQEDj6w1AQLcB4nbl3Ik7PukXSECP+2XAq0LeDrlJ3V1ivAySEucirUfAbu9WhpineFvZh4wAwQjxhBTy8udBmRJtN4Gdfl0K96qz9jZv7EAGUvlqSgGDwVvGQOBn9H5RosyoGlVmxY89ae5pijNP2qu7STmUZxzTqdctstcczaTbtofMTILHEBR/Wxbecg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.112.35) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com;
dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=FvXz5NWI86nJTupERLesvQWZbUhq8jqlMlFptAMIJ0M=;
b=XmkBeHhr7+Xz7NDoL92p+p1q7GNebmM40aSe8OTwp3p1Rx+uhqWBe8/SS/4mHNOYwIQM+i+OoO0cIEk3XF05QRyDpMLgLVZhjwXT8TIZDcQbhNAm2ydA83ILu0z7ecqj3sHDV/HHf6yGyd9pbCzRdK/WYW5dyYTgIzIeekLmHuG3gr8c9++jnYwLeWrzuwTyJy+hpfpbyf6+7J42ZVL6Fg72vWhZt4LIQ8fcxATDoj05H69qu62NMaDklAFLfGN7bl4rfsFGfGpKRSfJRVu6MVA0jztIepzJadwxivbN5RWi1Bt2QxqzM5IWXct3d/An00siuvbnYprvHA2tFMurqA==
Received: from DS7PR03CA0251.namprd03.prod.outlook.com (2603:10b6:5:3b3::16)
by MN2PR12MB4567.namprd12.prod.outlook.com (2603:10b6:208:263::12) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Wed, 14 Apr
2021 12:59:43 +0000
Received: from DM6NAM11FT030.eop-nam11.prod.protection.outlook.com
(2603:10b6:5:3b3:cafe::87) by DS7PR03CA0251.outlook.office365.com
(2603:10b6:5:3b3::16) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend
Transport; Wed, 14 Apr 2021 12:59:43 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35)
smtp.mailfrom=nvidia.com; gmail.com; dkim=none (message not signed)
header.d=none;gmail.com; dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.112.35 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.112.35; helo=mail.nvidia.com;
Received: from mail.nvidia.com (216.228.112.35) by
DM6NAM11FT030.mail.protection.outlook.com (10.13.172.146) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.4042.16 via Frontend Transport; Wed, 14 Apr 2021 12:59:43 +0000
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com
(172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 14 Apr
2021 12:57:25 +0000
Received: from nvidia.com (172.20.145.6) by DRHQMAIL107.nvidia.com
(10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 14 Apr
2021 12:57:21 +0000
From: Gregory Etelson <getelson@nvidia.com>
To: <orika@nvidia.com>
CC: <ajit.khaparde@broadcom.com>, <andrew.rybchenko@oktetlabs.ru>,
<dev@dpdk.org>, <ferruh.yigit@intel.com>, <jerinj@marvell.com>,
<jerinjacobk@gmail.com>, <olivier.matz@6wind.com>, <thomas@monjalon.net>,
<viacheslavo@nvidia.com>, <getelson@nvidia.com>, <matan@nvidia.com>,
<rasland@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>
Date: Wed, 14 Apr 2021 15:57:00 +0300
Message-ID: <20210414125700.12940-3-getelson@nvidia.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20210414125700.12940-1-getelson@nvidia.com>
References: <DM6PR12MB4987D87E9B87A07F2D85B562D6759@DM6PR12MB4987.namprd12.prod.outlook.com>
<20210414125700.12940-1-getelson@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
DRHQMAIL107.nvidia.com (10.27.9.16)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 554571f0-6ee0-468d-d23c-08d8ff452c2f
X-MS-TrafficTypeDiagnostic: MN2PR12MB4567:
X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
X-Microsoft-Antispam-PRVS: <MN2PR12MB45673D30F8DA9CEF8FFD5543A54E9@MN2PR12MB4567.namprd12.prod.outlook.com>
X-MS-Exchange-Transport-Forked: True
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hR458Wdp+SJG3T0sSuqmjj4U1nbYqGSdPEXgwiri2UWJLBFctByzIpv4pXcntLMN6u0XvhSHVaMJjSGnS39bJ5s4oaa2SX1usNrrswl8XLDmz22r/aNDZ9secOyCR7gSva/MpNc7U88vvNV0nzaYqcE08UKWROek07D41Rxd/5z5XYahtrgvE4Cz910yUZ9Q8lxOMM5UWqA7MsMNqnr0gP6c53jSGySN3W4BQvl460T7gc7rWWPTh2YHLEmm2OahP+xBzvlsfA8ApeakS2QzHMNPe5wfe/1McHatbOgOMyl6sBkeLM7/wnqkNVjm0fjHX4aBX4rM8z/MDoUxNPV22qEtK0vw1rwQSGWErdqa9PlXw7jJOYUpjCpsPTY6GrIvDUgrG6DuFHufu3g0l0mX+MrH2Uk8dv95x7LplM6fZJhmff2MdMGjn8iQ0kciFzvRS+geytDOoHex+GccK2CUO8ZPy5SwKVeeonpJIkjBAKrX/FvqDkxDqyXVv873X2xwjrioDk0BySTJPaAoLb7XfopYNQc66JShCp4g0lQEsxL+XRaN/p0QN1e/CqeP+O3RXwgAmD8sqD+UF/iY/4Kxrn9BbqrrXfJRXOzVH+/HqkdFTgAGHqEtciDmVa5nNwNSP+r+W38N0XboBUbvpglNaiVB+HxH1AApj+gp9dQYikA=
X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid02.nvidia.com; CAT:NONE;
SFS:(4636009)(39860400002)(396003)(136003)(346002)(376002)(36840700001)(46966006)(8676002)(36860700001)(86362001)(186003)(8936002)(426003)(16526019)(83380400001)(336012)(356005)(26005)(7636003)(316002)(478600001)(1076003)(37006003)(55016002)(7696005)(6666004)(2616005)(6862004)(6286002)(70586007)(47076005)(82310400003)(2906002)(6636002)(36906005)(4326008)(54906003)(70206006)(36756003)(82740400003)(5660300002);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2021 12:59:43.0813 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 554571f0-6ee0-468d-d23c-08d8ff452c2f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT030.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4567
Subject: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for integrity
item
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Ori Kam <orika@nvidia.com>
The integrity item allows the application to match
on the integrity of a packet.
use example:
match that packet integrity checks are ok. The checks depend on
packet layers. For example ICMP packet will not check L4 level.
flow create 0 ingress pattern integrity value mask 0x01 value spec 0x01
match that L4 packet is ok - check L2 & L3 & L4 layers:
flow create 0 ingress pattern integrity value mask 0xfe value spec 0xfe
Signed-off-by: Ori Kam <orika@nvidia.com>
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
app/test-pmd/cmdline_flow.c | 39 +++++++++++++++++++++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 +++++++++++++++
2 files changed, 67 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index fb7a3a8bd3..b5dec34325 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -289,6 +289,9 @@ enum index {
ITEM_GENEVE_OPT_TYPE,
ITEM_GENEVE_OPT_LENGTH,
ITEM_GENEVE_OPT_DATA,
+ ITEM_INTEGRITY,
+ ITEM_INTEGRITY_LEVEL,
+ ITEM_INTEGRITY_VALUE,
/* Validate/create actions. */
ACTIONS,
@@ -956,6 +959,7 @@ static const enum index next_item[] = {
ITEM_PFCP,
ITEM_ECPRI,
ITEM_GENEVE_OPT,
+ ITEM_INTEGRITY,
END_SET,
ZERO,
};
@@ -1307,6 +1311,19 @@ static const enum index item_geneve_opt[] = {
ZERO,
};
+static const enum index item_integrity[] = {
+ ITEM_INTEGRITY_LEVEL,
+ ITEM_INTEGRITY_VALUE,
+ ZERO,
+};
+
+static const enum index item_integrity_lv[] = {
+ ITEM_INTEGRITY_LEVEL,
+ ITEM_INTEGRITY_VALUE,
+ ITEM_NEXT,
+ ZERO,
+};
+
static const enum index next_action[] = {
ACTION_END,
ACTION_VOID,
@@ -3373,6 +3390,28 @@ static const struct token token_list[] = {
(sizeof(struct rte_flow_item_geneve_opt),
ITEM_GENEVE_OPT_DATA_SIZE)),
},
+ [ITEM_INTEGRITY] = {
+ .name = "integrity",
+ .help = "match packet integrity",
+ .priv = PRIV_ITEM(INTEGRITY,
+ sizeof(struct rte_flow_item_integrity)),
+ .next = NEXT(item_integrity),
+ .call = parse_vc,
+ },
+ [ITEM_INTEGRITY_LEVEL] = {
+ .name = "level",
+ .help = "integrity level",
+ .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED),
+ item_param),
+ .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, level)),
+ },
+ [ITEM_INTEGRITY_VALUE] = {
+ .name = "value",
+ .help = "integrity value",
+ .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED),
+ item_param),
+ .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, value)),
+ },
/* Validate/create actions. */
[ACTIONS] = {
.name = "actions",
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 36f0a328a5..58d4d712ab 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3783,6 +3783,13 @@ This section lists supported pattern items and their attributes, if any.
- ``s_field {unsigned}``: S field.
- ``seid {unsigned}``: session endpoint identifier.
+- ``integrity``: match packet integrity.
+
+ - ``level {unsigned}``: Packet encapsulation level the item should
+ apply to. See rte_flow_action_rss for details.
+ - ``value {unsigned}``: A bitmask that specify what packet elements
+ must be matched for integrity.
+
Actions list
^^^^^^^^^^^^
@@ -4917,6 +4924,27 @@ NVGRE encapsulation header and sent to port id 0.
testpmd> flow create 0 ingress transfer pattern eth / end actions
sample ratio 1 index 0 / port_id id 2 / end
+Sample integrity rules
+~~~~~~~~~~~~~~~~~~~~~~
+
+Integrity rules can be created by the following commands:
+
+Integrity rule that forwards valid TCP packets to group 1.
+TCP packet integrity is matched with the ``l4_ok`` bit 3.
+
+::
+
+ testpmd> flow create 0 ingress
+ pattern eth / ipv4 / tcp / integrity value mask 8 value spec 8 / end
+ actions jump group 1 / end
+
+Integrity rule that forwards invalid packets to application.
+General packet integrity is matched with the ``packet_ok`` bit 0.
+
+::
+
+ testpmd> flow create 0 ingress pattern integrity value mask 1 value spec 0 / end actions queue index 0 / end
+
BPF Functions
--------------
--
2.25.1