From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02EE7A0562; Wed, 14 Apr 2021 20:25:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8297161C57; Wed, 14 Apr 2021 20:25:17 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id ADDE7161C55 for ; Wed, 14 Apr 2021 20:25:16 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id E7B0220B8001; Wed, 14 Apr 2021 11:25:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E7B0220B8001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1618424715; bh=a3wF9Iei1MucN/ycCK9nfWcJPQx7EguIE3XvjYK6Y84=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EdX+5NG1WfVwOw4/GCjvo+GVncVteptR8cRtVEOlwvtKvxyugm8OgyhpxkBVCebOj 9S57RIlfbREGz9luJs68Ql13BdsvxUO+GxvGyioeIc96zGuFSFUSlODrbLNu+ZS7EN D046VHt0D8JcWPuehavRJnTqkB95nraMzS46mIcw= Date: Wed, 14 Apr 2021 11:25:15 -0700 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com Message-ID: <20210414182515.GC27344@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-7-git-send-email-jizh@linux.microsoft.com> <20210413231000.2c7f706b@sovereign> <20210413222257.GA27344@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210414171641.GB27344@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210414204531.2b7bbe48@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414204531.2b7bbe48@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 14, 2021 at 08:45:31PM +0300, Dmitry Kozlyuk wrote: > 2021-04-14 10:16 (UTC-0700), Jie Zhou: > > On Tue, Apr 13, 2021 at 03:22:57PM -0700, Jie Zhou wrote: > > > On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote: > > > > 2021-04-13 10:19 (UTC-0700), Jie Zhou: > > > > [...] > > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > > > > index fb7a3a8bd..9945adcf1 100644 > > > > > --- a/app/test-pmd/cmdline_flow.c > > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > > @@ -31,6 +31,12 @@ > > > > > > > > > > #include "testpmd.h" > > > > > > > > > > +#ifdef RTE_EXEC_ENV_WINDOWS > > > > > +#ifndef IPDEFTTL > > > > > +#define IPDEFTTL 64 > > > > > +#endif > > > > > +#endif > > > > > + > > > > > /** Parser token indices. */ > > > > > enum index { > > > > > /* Special tokens. */ > > > > > > > > IPDEFTTL is used in some other apps and examples. > > > > If you follow Tal's advice and base your work on "Do not expose POSIX > > > > symbols" series, then please move this to . > > > > > > I applied "eal/windows:do not expose POSIX symbols" per your and Tal's advices, but hit error LNK2019: unresolved external symbol strdup reference in function log_save_level". I am using clang version 10.0.0. > > > > [Update] Seems the problem is at applying the patch series, even though it showed all sucessfully applied, but somehow in eal_common_log.c the include of was not added. After add include rte_os_shim.h, build completes. > > Are you applying v9? It includes this exact fix. Thanks. Applied V8 by mistake which has no this change. Now has no issue.