From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35385A0562; Wed, 14 Apr 2021 19:45:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2219B161C10; Wed, 14 Apr 2021 19:45:35 +0200 (CEST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mails.dpdk.org (Postfix) with ESMTP id 864544013F for ; Wed, 14 Apr 2021 19:45:33 +0200 (CEST) Received: by mail-lj1-f178.google.com with SMTP id m7so13372513ljp.10 for ; Wed, 14 Apr 2021 10:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w/0MDh35jvSeCFlsibXd4GfnCw8mtKY5veZ8GLg4Lxs=; b=QwAHFVPMF2JVbOnOWDMDge5XK3GZG3ri7E/1kdevXVHYXHExPpJsA1gxd1QJ6Qz7/5 6QODwIV5ce40Eq0rloA9EUJCfislznU0Vk2emNT0EjMWzrcYzI9wf/s6PN8DOEWuRwJ/ QX1L7AxGtiBo4j2CWz44rBcqMhc86FwumOvKRSDi9fi0H38HWsXo45lZySIRfttiIS+1 shjqxmvvCVlwklT+6E+eBewX54Mi1XfzlaZFq5OqzOIt24sXV8NgYSg/NOABukrlswIR EVm4cFewOT7m+PiTDYSB/h/hHdkRFRDIalqQghcC0sWyBRPi0iVc5AcA8df+boC6zl+A J2Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w/0MDh35jvSeCFlsibXd4GfnCw8mtKY5veZ8GLg4Lxs=; b=p3DonKTqnUjlrDzTcKE5DT63ln/fUd43aqNHyJlFZ4lptNlom8SpWOlHbgounc/TtL JdIh3hth+LuyfV9+qMtUlghAlQd20kKW9nNh5eJBSAM3uj7Vn+reArju6NvkDm6D5gp7 9JUzGl6blMrmHlmSTeixIOjK3prMFpR3DDx2OpFCT+k1imXhED0sa/CAGDBNtpNZoVJm 5vWYvbtdxzeL8sga2Bk3o95U/Wf1sGbfqpo2kIJbsOLFy2CCrt3R/9jYIf4Fn8rtvWEd e1t1ZNO8Qlx12coPvVfP4J3ws0WINQgv6NHhrZ7sLmJ97bbqKHeTqkUmnCv2sAo2ktTX 6QYg== X-Gm-Message-State: AOAM5312S0iyOyqfHF4pcy91ivN8SpUoM8OwtjJuUcY4lqH/LS7T5mRQ DiivE8Zez4wQLrF5h9Ha/xs= X-Google-Smtp-Source: ABdhPJyvjJYNrU1RzJ4KVyepCCr9/lXDoUj/3B10dLT0H1DBaaXtFPrXZuYoNJ5ncjAHakpm0dyCEQ== X-Received: by 2002:a2e:9989:: with SMTP id w9mr23867526lji.163.1618422333069; Wed, 14 Apr 2021 10:45:33 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id w16sm80095lfu.160.2021.04.14.10.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 10:45:32 -0700 (PDT) Date: Wed, 14 Apr 2021 20:45:31 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com Message-ID: <20210414204531.2b7bbe48@sovereign> In-Reply-To: <20210414171641.GB27344@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-7-git-send-email-jizh@linux.microsoft.com> <20210413231000.2c7f706b@sovereign> <20210413222257.GA27344@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210414171641.GB27344@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-14 10:16 (UTC-0700), Jie Zhou: > On Tue, Apr 13, 2021 at 03:22:57PM -0700, Jie Zhou wrote: > > On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote: > > > 2021-04-13 10:19 (UTC-0700), Jie Zhou: > > > [...] > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > > > index fb7a3a8bd..9945adcf1 100644 > > > > --- a/app/test-pmd/cmdline_flow.c > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > @@ -31,6 +31,12 @@ > > > > > > > > #include "testpmd.h" > > > > > > > > +#ifdef RTE_EXEC_ENV_WINDOWS > > > > +#ifndef IPDEFTTL > > > > +#define IPDEFTTL 64 > > > > +#endif > > > > +#endif > > > > + > > > > /** Parser token indices. */ > > > > enum index { > > > > /* Special tokens. */ > > > > > > IPDEFTTL is used in some other apps and examples. > > > If you follow Tal's advice and base your work on "Do not expose POSIX > > > symbols" series, then please move this to . > > > > I applied "eal/windows:do not expose POSIX symbols" per your and Tal's advices, but hit error LNK2019: unresolved external symbol strdup reference in function log_save_level". I am using clang version 10.0.0. > > [Update] Seems the problem is at applying the patch series, even though it showed all sucessfully applied, but somehow in eal_common_log.c the include of was not added. After add include rte_os_shim.h, build completes. Are you applying v9? It includes this exact fix.