From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 471E5A0A02; Thu, 15 Apr 2021 00:08:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C747161D79; Thu, 15 Apr 2021 00:08:12 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 8C5C3161D75 for ; Thu, 15 Apr 2021 00:08:10 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id 12so35624947lfq.13 for ; Wed, 14 Apr 2021 15:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ct+DTuOwVr6M1iRfGdtFSXsd90uWVbQ3tecAsz3kJqk=; b=IfDJgruKKrzz2iQdDfF+szRspps6iWu1PL73aNOOdsoySR+x8GROVcTPMxmhYkkPav h3KwCQRMLJ/jnx3CwVdMDYlGvUVLwASIKNFkItMZyRuDkxWJCsuwJk8Mn/9n1BY1TXPZ F8d8xdV3vt8eLWvcQPWxqPDM96EoKA8aeqLlakGwSr/sACBE4wZt2ElLITQOvj/dJKca 8qQ0cOxbBEnIql4g7wf9YfHny3/ROfiFV8VrMKcCNHsiS3F/wkMwzU1ru3qHpuST8znJ PN6xjnI+4WB9oBwD/5vHHHlpZSPxK8hA/ezaHPJWoxZsrfkJVAHHQkfeNqqjinLCukOS eP+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ct+DTuOwVr6M1iRfGdtFSXsd90uWVbQ3tecAsz3kJqk=; b=GcaaTxX8uyERXu8Iq84RKodUkkwb8LrRY6SSbTsvFkVQX/kwoOO4LN0lOnaHV5IP/+ R5RND43xB2A661Fp22LlJAdPuF7bW6D+UquwR0JSF0KfOV84M+oMxA8rqhd5x8Y1K6AG Ho9A/GkfWIaLdf/KLBhcxOkpYgOP7+87JGnXy8Gnkw+MpZFHXgvmqEapt2d8DfgzsqLQ cOIacXP5uTXLhvvvkgpWyMpeb71drEJ+gj07IYEQCVp/uNmSVmTUAkPYXMBgqJiedWyA /n9uaxB7pIKBAk+9iiA3ZYRqLylrqPJMe7eV8s/UIUPJtqOskL5QnXEtMAobLUmlQnpn 2Jlw== X-Gm-Message-State: AOAM533JbYhnpz6IuUt+vd0wTc5EnocStAZQ9FcLK/pJqgpmaRUUiiC6 C4Lywr6xOakOx5mMQQ82HTA= X-Google-Smtp-Source: ABdhPJzg+GX3HJI53gjU7nMQjI6wUD34eTds/UxmdmRAaXeVs7S9p0GE35eqxmrfQVCHX4W3FmCekA== X-Received: by 2002:a19:34f:: with SMTP id 76mr230214lfd.246.1618438090197; Wed, 14 Apr 2021 15:08:10 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id a17sm279411lfg.20.2021.04.14.15.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 15:08:09 -0700 (PDT) Date: Thu, 15 Apr 2021 01:08:08 +0300 From: Dmitry Kozlyuk To: Ranjit Menon , Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20210415010808.0d33a835@sovereign> In-Reply-To: <7340b084-cca7-88da-8656-dafa4348cfc0@intel.com> References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <2549908.9JeyF6cTkx@thomas> <3072229.f5VMXNVXpi@thomas> <7340b084-cca7-88da-8656-dafa4348cfc0@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-14 14:47 (UTC-0700), Ranjit Menon: > On 4/14/2021 2:42 PM, Thomas Monjalon wrote: > > 14/04/2021 23:34, Ranjit Menon: > >> On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > >>> 13/04/2021 09:00, Dmitry Kozlyuk: > >>>> Hi Ranjit, > >>>> > >>>> 2021-04-12 21:46 (UTC-0700), Ranjit Menon: > >>>> [...] > >>>>> The change to remove the networking shim breaks l2fwd compilation on > >>>>> Windows, since l2fwd/main.c includes netinet/in.h explicitly. > >>>>> > >>>>> How do you propose we fix this, only for Windows? > >>>> This include is redundant for this file on all platforms, it can be removed. > >>>> Since -Dexamples=all doesn't work on Windows because of missing dependencies, > >>>> I wonder which of them need fixing. > >>> Let's fix the examples which are supported on Windows. > >>> Other examples may require more updates anyway. > >>> > >> Thanks, Thomas. For now, this is only required in l2fwd. > > Only l2fwd is supported on Windows? > > > >> Dmitry, can you please include this in your patch 4/4? > > Ranjit, if you tell me what exactly is needed, I can do it > > and merge the series quickly. I've just sent v10 with all required fixes. > Sure, Thomas. In l2wfd/main.c, all we need to do is remove the #include > line. > > This include file will not exist on Windows anymore, and Dmitry > determined that this include is not required in l2fwd on all platforms. For the reference, complete list of examples that can build for Windows: helloworld cmdline flow_filtering ipv4_multicast l2fwd link_status_interrupt qos_meter rxtx_callbacks (-Wformat with clang) service_cores skeleton