From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83FAEA0C41; Fri, 16 Apr 2021 18:26:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41C6740687; Fri, 16 Apr 2021 18:26:20 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 1BC0D40150 for ; Fri, 16 Apr 2021 18:26:17 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id j32so4769889pgm.6 for ; Fri, 16 Apr 2021 09:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JFZT4NzVaOaS24MjN+sHYiO9BO8XN3R5SdeLKFxJS5w=; b=Zavh3aq3aGZ+e1n95W1JaiFiVsFeDUTHo6vGEQIEokBcWzUVAX0oZdIEMpHWG0xske l5TQFoU4JXUpRq74CUl97l/33dHOAMcDiBu+VRDO/ayl3vBnUyDaeygw66kywJ8Xa8tS yQEw7+CXJUnj19GCRYldQL4d6/5BH0XnnOTHmcyOLknH3eljNEPViK/ChfsZxMNXKZMh OM+PcYlh2G0HWRslacK8CHOBrBdFQMRvVPIWzWCM9bEmfQqh57h1we/lIB//SI6EV8zU QGXsCMzVNK0oiwKCAnsEgAhdxMFmZmvldYZAG0kvbzgmyyFR41AQ8dj7xAPhnOffAWoA 6ObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JFZT4NzVaOaS24MjN+sHYiO9BO8XN3R5SdeLKFxJS5w=; b=GUzNWtoDbAIDDlV7xppYxF8fSOj8ttI2SGs7eK73HT/PS45xyutVPxGkgitpPRprO7 cesebMZhBHj55VeCiuIEoENGArBMf56zR6SzMLf/G08RzgX0dn5X/KtaE7bI6Vc0Y5GO E+OFpCbr9GnsaH8/vRp/dJVKFaU0dYQtMJ7Luy5UsqyxLTi2Kpn2Kbgoto70VaQCr85s 1a/NzRDstzQEau3ZlMMkDxeMNsYotXQeAABPY/q5MOt5aph5c1Kli6kEEbqJxgVLaoiU //n8/TSus+g9BO74V7Yj1qUZGTkRvvWiQQ5zlSU5XuYVdZv49ZbJhsNrJkIIkZM3GiUX qBkw== X-Gm-Message-State: AOAM530jU9ReHFt9wcQpVjFkOtMko6shvRMujMcYGDjC4JhDphdOAKNO fUpgESaHBuIeqzS8GP7ygyr9+g== X-Google-Smtp-Source: ABdhPJyixWpYPp8j16sWuhPBF0ErXin3uNc8VbKOITv6EEpo7H7SU5qS0zrvHDCWjJyVgkb/FrcKLQ== X-Received: by 2002:aa7:91d1:0:b029:1fe:2a02:73b9 with SMTP id z17-20020aa791d10000b02901fe2a0273b9mr8683559pfa.2.1618590377126; Fri, 16 Apr 2021 09:26:17 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id 1sm5607531pjx.46.2021.04.16.09.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 09:26:16 -0700 (PDT) Date: Fri, 16 Apr 2021 09:25:15 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: , , , Message-ID: <20210416092515.5e1135d9@hermes.local> In-Reply-To: <1618484959-4360-1-git-send-email-humin29@huawei.com> References: <1618046334-39857-1-git-send-email-humin29@huawei.com> <1618484959-4360-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 15 Apr 2021 19:09:19 +0800 "Min Hu (Connor)" wrote: > + RTE_ETHDEV_LOG(ERR, "Failed to get owner id by NULL\n"); This message is awkward wording. It would be good time to fix something that has causes problems. Redefine RTE_ETHDEV_LOG to include the function name. There are several places where same log message can come from different ethdev functions. Then change the error you added to: RTE_ETHDEV_LOG(ERR, "NULL owner id"); Which would result in: eth_dev_owner_set: NULL owner id