DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows
@ 2021-04-15 21:36 Dmitry Kozlyuk
  2021-04-16  6:44 ` Juraj Linkeš
  2021-04-16 20:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
  0 siblings, 2 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-04-15 21:36 UTC (permalink / raw)
  To: dev; +Cc: Dmitry Kozlyuk, Juraj Linkeš, Bruce Richardson

buildtools/list-dir-globs.py printed paths with OS directory separator,
which is "/" on Unices and "\" on Windows, while Meson code always
expected "/". This resulted it all drivers being disabled on Windows.

Replace "\" with "/" in script output. Forward slash is a valid,
although non-default, separator on Windows, so no paths can be broken
by this substitution.

Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 buildtools/list-dir-globs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/list-dir-globs.py b/buildtools/list-dir-globs.py
index 911e267335..d824360d39 100755
--- a/buildtools/list-dir-globs.py
+++ b/buildtools/list-dir-globs.py
@@ -17,4 +17,4 @@
     if path:
         for p in iglob(os.path.join(root, path)):
             if os.path.isdir(p):
-                print(os.path.relpath(p))
+                print(os.path.relpath(p).replace('\\', '/'))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows
  2021-04-15 21:36 [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows Dmitry Kozlyuk
@ 2021-04-16  6:44 ` Juraj Linkeš
  2021-04-16  9:14   ` Bruce Richardson
  2021-04-16 20:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
  1 sibling, 1 reply; 5+ messages in thread
From: Juraj Linkeš @ 2021-04-16  6:44 UTC (permalink / raw)
  To: Dmitry Kozlyuk, dev; +Cc: Bruce Richardson



> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Sent: Thursday, April 15, 2021 11:36 PM
> To: dev@dpdk.org
> Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Juraj Linkeš
> <juraj.linkes@pantheon.tech>; Bruce Richardson <bruce.richardson@intel.com>
> Subject: [PATCH] buildtools: fix all drivers disabled on Windows
> 
> buildtools/list-dir-globs.py printed paths with OS directory separator, which is
> "/" on Unices and "\" on Windows, while Meson code always expected "/". This
> resulted it all drivers being disabled on Windows.
> 
> Replace "\" with "/" in script output. Forward slash is a valid, although non-
> default, separator on Windows, so no paths can be broken by this substitution.
> 
> Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>

This patch was only the latest that changed the code if the file, but not the logic related to path separators. I think you patch fixes the original commit ab9407c3addd.

> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  buildtools/list-dir-globs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/buildtools/list-dir-globs.py b/buildtools/list-dir-globs.py index
> 911e267335..d824360d39 100755
> --- a/buildtools/list-dir-globs.py
> +++ b/buildtools/list-dir-globs.py
> @@ -17,4 +17,4 @@
>      if path:
>          for p in iglob(os.path.join(root, path)):
>              if os.path.isdir(p):
> -                print(os.path.relpath(p))
> +                print(os.path.relpath(p).replace('\\', '/'))
> --
> 2.29.3
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows
  2021-04-16  6:44 ` Juraj Linkeš
@ 2021-04-16  9:14   ` Bruce Richardson
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2021-04-16  9:14 UTC (permalink / raw)
  To: Juraj Linkeš; +Cc: Dmitry Kozlyuk, dev

On Fri, Apr 16, 2021 at 06:44:34AM +0000, Juraj Linkeš wrote:
> 
> 
> > -----Original Message-----
> > From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Sent: Thursday, April 15, 2021 11:36 PM
> > To: dev@dpdk.org
> > Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Juraj Linkeš
> > <juraj.linkes@pantheon.tech>; Bruce Richardson <bruce.richardson@intel.com>
> > Subject: [PATCH] buildtools: fix all drivers disabled on Windows
> > 
> > buildtools/list-dir-globs.py printed paths with OS directory separator, which is
> > "/" on Unices and "\" on Windows, while Meson code always expected "/". This
> > resulted it all drivers being disabled on Windows.
> > 
> > Replace "\" with "/" in script output. Forward slash is a valid, although non-
> > default, separator on Windows, so no paths can be broken by this substitution.
> > 
> > Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> > Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> 
> This patch was only the latest that changed the code if the file, but not the logic related to path separators. I think you patch fixes the original commit ab9407c3addd.
> 
> > 
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

+1 for the correction for the fixes line.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> > ---
> >  buildtools/list-dir-globs.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/buildtools/list-dir-globs.py b/buildtools/list-dir-globs.py index
> > 911e267335..d824360d39 100755
> > --- a/buildtools/list-dir-globs.py
> > +++ b/buildtools/list-dir-globs.py
> > @@ -17,4 +17,4 @@
> >      if path:
> >          for p in iglob(os.path.join(root, path)):
> >              if os.path.isdir(p):
> > -                print(os.path.relpath(p))
> > +                print(os.path.relpath(p).replace('\\', '/'))
> > --
> > 2.29.3
> > 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v2] buildtools: fix all drivers disabled on Windows
  2021-04-15 21:36 [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows Dmitry Kozlyuk
  2021-04-16  6:44 ` Juraj Linkeš
@ 2021-04-16 20:48 ` Dmitry Kozlyuk
  2021-04-17 10:48   ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-04-16 20:48 UTC (permalink / raw)
  To: dev; +Cc: Dmitry Kozlyuk, stable, Bruce Richardson

buildtools/list-dir-globs.py printed paths with OS directory separator,
which is "/" on Unices and "\" on Windows, while Meson code always
expected "/". This resulted in all drivers being disabled on Windows.

Replace "\" with "/" in script output. Forward slash is a valid,
although non-default, separator on Windows, so no paths can be broken
by this substitution.

Fixes: ab9407c3addd ("build: allow using wildcards to disable drivers")
Cc: stable@dpdk.org

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: Change fixes line, correct a typo (Juraj, Bruce).

Not sure if it's worth backporting: it wasn't an issue in 20.11
and the patch won't apply as-is.

 buildtools/list-dir-globs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/list-dir-globs.py b/buildtools/list-dir-globs.py
index 911e267335..d824360d39 100755
--- a/buildtools/list-dir-globs.py
+++ b/buildtools/list-dir-globs.py
@@ -17,4 +17,4 @@
     if path:
         for p in iglob(os.path.join(root, path)):
             if os.path.isdir(p):
-                print(os.path.relpath(p))
+                print(os.path.relpath(p).replace('\\', '/'))
-- 
2.29.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] buildtools: fix all drivers disabled on Windows
  2021-04-16 20:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
@ 2021-04-17 10:48   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-04-17 10:48 UTC (permalink / raw)
  To: Dmitry Kozlyuk; +Cc: dev, stable, Bruce Richardson, juraj.linkes

16/04/2021 22:48, Dmitry Kozlyuk:
> buildtools/list-dir-globs.py printed paths with OS directory separator,
> which is "/" on Unices and "\" on Windows, while Meson code always
> expected "/". This resulted in all drivers being disabled on Windows.
> 
> Replace "\" with "/" in script output. Forward slash is a valid,
> although non-default, separator on Windows, so no paths can be broken
> by this substitution.
> 
> Fixes: ab9407c3addd ("build: allow using wildcards to disable drivers")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: Change fixes line, correct a typo (Juraj, Bruce).
> 
> Not sure if it's worth backporting: it wasn't an issue in 20.11
> and the patch won't apply as-is.

The commit you mention was introduced in 21.02.
No matter which release it is, it is good to suggest backporting
for those who need to maintain an old release even if not upstream.

Applied, thanks



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-17 10:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 21:36 [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows Dmitry Kozlyuk
2021-04-16  6:44 ` Juraj Linkeš
2021-04-16  9:14   ` Bruce Richardson
2021-04-16 20:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-04-17 10:48   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git