From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28DDFA0548; Mon, 19 Apr 2021 21:45:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E62624146C; Mon, 19 Apr 2021 21:45:20 +0200 (CEST) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mails.dpdk.org (Postfix) with ESMTP id D2CAD4145F for ; Mon, 19 Apr 2021 21:45:19 +0200 (CEST) Received: by mail-lj1-f175.google.com with SMTP id u20so40755913lja.13 for ; Mon, 19 Apr 2021 12:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SiV6UTwolPACDX4+VYwejwig7+pyUEtulDwYB3VF6qg=; b=DUdwZ0nw/6Xf/BqJ03zjS23jXSLKkEBDLpiDcWB7ysgvUQnfo9AXtTjp3iCZp+WCDJ iB7U9F9rCvp/18OTP3DN/Xrb+CGWzyzpqmbbOSZCVUlWC4HhELp8bNEW1qmbXgJVS88D PoTdLUmTB3d11GavYhOCoqiQ6a3DaD5poe5WeawZlSuY5jfsoeLSHDVPGLAXtkLKF5Wb XxMhvRTgej+SF0NL85tArQdOlaNpycWwQBtvLTMe69MpmyKc8kbkkV6FoyDWuE+gI/xW hoAaD1Wa2wmTyQmrbBb0RCBriWwI4nzur5UOGo0VkkK+GEh/XrWsMeMXWiBi6SAULWYW E9Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SiV6UTwolPACDX4+VYwejwig7+pyUEtulDwYB3VF6qg=; b=ri7DEe2ahLnqkZ1mMjy/HJSol2derRtSoknkfNzpqmKbe9PgDSTJcqcWjuIoUBA7mo GMbdMPikXaVeETYx/JrCGdwnKNyMGK+PnURczXRzm7LTmOGiJKaGsGMRHI8VkKBhZq4S s0LZAt/ZL3wJragGFKWkvo94wyQ+OboWC4dGW5ieZDbeEMY8tfiTNLCG1Wnbk2lPyxPV IBNA6XQWkqJOX6ngfknKhg7uXagDI2G8aeZsg1fA+GA4BDcEtqz8mdlJDJnndVsGpjA3 dnIBqoUtUzsiR/9mbxIaOF4eFYpoiFUDjUZtVEqgHVcK3/tqQ38883INBtR840LrtkeR /5tQ== X-Gm-Message-State: AOAM532TIeY7U/exHkyH0E1tbdIjiOZzHGK5UaHK424YVHNiaOEocuCa 3yCo4Si/h+61dUhBbjnHqUA= X-Google-Smtp-Source: ABdhPJwBCYsuqXrRrVw9ZyjxCLA0w5XmhMQNkrns8tnSzbt2CCBb6UMKdrTmF1ZbOSn+UPke6AieFg== X-Received: by 2002:a2e:a7d4:: with SMTP id x20mr12535947ljp.285.1618861519436; Mon, 19 Apr 2021 12:45:19 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v7sm1162780lfo.297.2021.04.19.12.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 12:45:18 -0700 (PDT) Date: Mon, 19 Apr 2021 22:45:16 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" Message-ID: <20210419224516.54b7c446@sovereign> In-Reply-To: References: <20210418170803.15684-1-talshn@nvidia.com> <2018619.JnGxiWPmQR@thomas> <20210418232330.2471f913@sovereign> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tal, 2021-04-19 18:06 (UTC+0000), Tal Shnaiderman: > I also noticed warnings in clang on my setup that are related to rte_os_shim.h: > > [185/314] Compiling C object drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_common_mp.c.obj. > In file included from ../drivers/common/mlx5/mlx5_common_mp.c:13: > In file included from ..\drivers\common/mlx5/mlx5_common_utils.h:8: > In file included from ..\drivers\common/mlx5/mlx5_common.h:17: > ..\lib/librte_eal/windows/include\rte_os_shim.h:22:51: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments] > #define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__) > ^ > However don't see it in CI, I'm using clang version 9.0.1 This warning only appears with --buildtype=debug, that's why I missed it. I don't see a good way to fix it except #define open _open, RTE_FMT_xxx approach is not applicable here.