From: Jack Min <jackmin@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jeff Guo <jia.guo@intel.com>, Ori Kam <orika@nvidia.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"xiaoyun.li@intel.com" <xiaoyun.li@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"ting.xu@intel.com" <ting.xu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment
Date: Tue, 20 Apr 2021 02:21:13 +0000 [thread overview]
Message-ID: <20210420022112.bw4lzk3a74t7ajhk@nvidia.com> (raw)
In-Reply-To: <3f464ec1-f6c3-1969-611d-c000b1172d16@intel.com>
On Mon, 21-04-19, 16:40, Ferruh Yigit wrote:
> On 4/19/2021 8:43 AM, Jack Min wrote:
> > On Tue, 21-04-13, 16:10, Jeff Guo wrote:
> > > Add the new items to support the flow configuration for IP fragment
> > > packets.
> > >
> > > Signed-off-by: Ting Xu <ting.xu@intel.com>
> > > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> > > ---
> > > app/test-pmd/cmdline_flow.c | 21 ++++++++++++++++++++-
> > > 1 file changed, 20 insertions(+), 1 deletion(-)
> >
> > [...snip...]
> >
> > > + [ITEM_IPV4_ID] = {
> > > + .name = "packet_id",
> > > + .help = "fragment packet id",
> > > + .next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param),
> > > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4,
> > > + hdr.packet_id)),
> > > + },
> > > [ITEM_IPV4_FRAGMENT_OFFSET] = {
> > > .name = "fragment_offset",
> > > .help = "fragmentation flags and fragment offset",
> > > @@ -2969,12 +2980,20 @@ static const struct token token_list[] = {
> > > },
> > > [ITEM_IPV6_FRAG_EXT_FRAG_DATA] = {
> > > .name = "frag_data",
> > > - .help = "Fragment flags and offset",
> > > + .help = "fragment flags and offset",
> > Will it be better to have a seperate fix patch for this ?
> >
>
> You refer the case update of the help string, 'F' -> 'f', right?
Right.
> If so this is so small, and cosmetic, update, I think no need to have its
> own patch, and while this patch is touching related area, acceptable to fix
> it here.
Yes it's so small so I don't insist my point. :)
Reviewed-by: Xiaoyu Min <jackmin@nvidia.com>
-Jack
next prev parent reply other threads:[~2021-04-20 2:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 3:12 [dpdk-dev] [PATCH v1 0/4] support flow for IP fragment in IAVF Jeff Guo
2021-03-17 3:12 ` [dpdk-dev] [PATCH v1 1/4] app/testpmd: add packet id for IP fragment Jeff Guo
2021-03-17 3:12 ` [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto header " Jeff Guo
2021-03-17 3:12 ` [dpdk-dev] [PATCH v1 3/4] net/iavf: support RSS hash " Jeff Guo
2021-03-17 3:12 ` [dpdk-dev] [PATCH v1 4/4] net/iavf: support FDIR for IP fragment packet Jeff Guo
2021-03-19 7:57 ` Li, Xiaoyun
2021-03-23 0:58 ` Guo, Jia
2021-03-24 13:48 ` [dpdk-dev] [PATCH v2 0/4] support flow for IP fragment in IAVF Jeff Guo
2021-03-24 13:48 ` [dpdk-dev] [PATCH v2 1/4] app/testpmd: add packet id for IP fragment Jeff Guo
2021-03-24 13:48 ` [dpdk-dev] [PATCH v2 2/4] common/iavf: add proto header " Jeff Guo
2021-03-24 13:48 ` [dpdk-dev] [PATCH v2 3/4] net/iavf: support RSS hash " Jeff Guo
2021-03-24 13:48 ` [dpdk-dev] [PATCH v2 4/4] net/iavf: support FDIR for IP fragment packet Jeff Guo
2021-04-11 6:01 ` [dpdk-dev] [PATCH v3 1/4] app/testpmd: add packet id for IP fragment Jeff Guo
2021-04-11 6:01 ` [dpdk-dev] [PATCH v3 2/4] common/iavf: add proto header " Jeff Guo
2021-04-11 6:01 ` [dpdk-dev] [PATCH v3 3/4] net/iavf: support RSS hash " Jeff Guo
2021-04-11 6:01 ` [dpdk-dev] [PATCH v3 4/4] net/iavf: support FDIR for IP fragment packet Jeff Guo
2021-04-12 8:45 ` Xu, Ting
2021-04-13 1:57 ` Guo, Jia
2021-04-11 6:07 ` [dpdk-dev] [PATCH v3 0/3] support flow for IP fragment in ICE Jeff Guo
2021-04-11 6:59 ` [dpdk-dev] [PATCH v3 0/4] support flow for IP fragment in IAVF Jeff Guo
2021-04-11 6:59 ` [dpdk-dev] [PATCH v3 1/4] app/testpmd: add packet id for IP fragment Jeff Guo
2021-04-11 6:59 ` [dpdk-dev] [PATCH v3 2/4] common/iavf: add proto header " Jeff Guo
2021-04-11 6:59 ` [dpdk-dev] [PATCH v3 3/4] net/iavf: support RSS hash " Jeff Guo
2021-04-11 6:59 ` [dpdk-dev] [PATCH v3 4/4] net/iavf: support FDIR for IP fragment packet Jeff Guo
2021-04-13 8:10 ` [dpdk-dev] [PATCH v4 0/4] support flow for IP fragment in IAVF Jeff Guo
2021-04-13 8:10 ` [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment Jeff Guo
2021-04-19 7:43 ` Jack Min
2021-04-19 15:40 ` Ferruh Yigit
2021-04-20 2:21 ` Jack Min [this message]
2021-04-19 15:37 ` Ferruh Yigit
2021-04-19 17:45 ` Ori Kam
2021-04-19 23:01 ` Ferruh Yigit
2021-04-13 8:10 ` [dpdk-dev] [PATCH v4 2/4] common/iavf: add proto header " Jeff Guo
2021-04-13 8:10 ` [dpdk-dev] [PATCH v4 3/4] net/iavf: support RSS hash " Jeff Guo
2021-04-13 8:10 ` [dpdk-dev] [PATCH v4 4/4] net/iavf: support FDIR for IP fragment packet Jeff Guo
2021-04-13 9:30 ` [dpdk-dev] [PATCH v4 0/4] support flow for IP fragment in IAVF Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420022112.bw4lzk3a74t7ajhk@nvidia.com \
--to=jackmin@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=ting.xu@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).