* [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm
@ 2021-04-20 4:08 Kalesh A P
2021-04-20 5:31 ` Ajit Khaparde
0 siblings, 1 reply; 2+ messages in thread
From: Kalesh A P @ 2021-04-20 4:08 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Driver cancels the health check alarm only if error recovery is enabled
in the FW. This can cause an issue. There is a small window where the
driver receives the async event from fw and port close is invoked
immediately. Driver clears BNXT_FLAG_RECOVERY_ENABLED flag when it gets
the async event from FW. As a result, the health check alarm will not
get canceled during port close and causes a segfault when the alarm tries
to read Heartbeat register.
Fix this by cancelling the health check alarm unconditionally during
port stop.
Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 9da817f..f5d2dc8 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4274,9 +4274,6 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)
static void bnxt_cancel_fw_health_check(struct bnxt *bp)
{
- if (!bnxt_is_recovery_enabled(bp))
- return;
-
rte_eal_alarm_cancel(bnxt_check_fw_health, (void *)bp);
bp->flags &= ~BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;
}
--
2.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm
2021-04-20 4:08 [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm Kalesh A P
@ 2021-04-20 5:31 ` Ajit Khaparde
0 siblings, 0 replies; 2+ messages in thread
From: Ajit Khaparde @ 2021-04-20 5:31 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
On Mon, Apr 19, 2021 at 8:46 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Driver cancels the health check alarm only if error recovery is enabled
> in the FW. This can cause an issue. There is a small window where the
> driver receives the async event from fw and port close is invoked
> immediately. Driver clears BNXT_FLAG_RECOVERY_ENABLED flag when it gets
> the async event from FW. As a result, the health check alarm will not
> get canceled during port close and causes a segfault when the alarm tries
> to read Heartbeat register.
>
> Fix this by cancelling the health check alarm unconditionally during
> port stop.
>
> Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 9da817f..f5d2dc8 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -4274,9 +4274,6 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)
>
> static void bnxt_cancel_fw_health_check(struct bnxt *bp)
> {
> - if (!bnxt_is_recovery_enabled(bp))
> - return;
> -
> rte_eal_alarm_cancel(bnxt_check_fw_health, (void *)bp);
> bp->flags &= ~BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;
> }
> --
> 2.10.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-20 5:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 4:08 [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm Kalesh A P
2021-04-20 5:31 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).