From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1BCDA0548; Tue, 20 Apr 2021 19:56:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7348841735; Tue, 20 Apr 2021 19:56:17 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 216DA41439 for ; Tue, 20 Apr 2021 19:56:16 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id c17so26102740pfn.6 for ; Tue, 20 Apr 2021 10:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZOgW+m7sNIYsDGkimPLAGMTnnDoxDxC0gLI75b/sgrQ=; b=lcqjr5ct23OwmUnseqzuL5WWbB06fQeK9eP8NVlefhAuGPR/hSJJgC8v434aPaBnyM p7dKuRP2f9xk1IKuLEKQdH7P+coRjQ7cTPbdd5AJ9jXNSRPH3dk0xHdvJpb+BZcdSKZ4 0+3oKokNcyE7WI6Sa1VQ/q13Zksapf+d0zKfobkBOhwOpHC/as5XmkDdhBvLR0NXBVsN LqlTwoGsgXNIeX5CJHdeZoXc3rsL3ET46OjMM1ISD1ZU9yuE5do12pmyuPbzx3J/TlRL 6+xe421uAve0S8NgRUgZnIVJ2YPIQLEg1MckEILLLd5CNxptqoeqeWx3Kx6ADcm7q2/K C+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZOgW+m7sNIYsDGkimPLAGMTnnDoxDxC0gLI75b/sgrQ=; b=dLRFXqoT/nkb6p63qW5J36FQ1mhcsLNkgTuvzXNp79UHUtL4ZOy7fIazIWYasRqSua 5b2AmpmWL80at0rPZxz97TLgKghpCKFvppwnmzhiouaXFUuFNnwNt3T7C66S8WcQ+CKL B+1Pc7ifAo89u0H2w/EVMzpud61xAM2/BlZkadQ1fhVg+xzpAVmdPsfEkPSAV/BEniP9 VTlV9/YTKANKoQxdxLCqpmd6usfpmjbIQ2SSvvkn00B9Ush77s2xRUFxBN9jgCzF4jvl GUbrqAS/1ieB8Au4hiQvHhxrbr+O8PCn/V+aGWjnJctQtkSQE9+AhTobFWib7K4xzkz9 PBfA== X-Gm-Message-State: AOAM533Ea7Ipkftrh0dPJgUaTtee458m2AikZyhIyY66PZYlQDt3VACb NF3tJZ56BiBEBQ+5cV1WEiLx9A== X-Google-Smtp-Source: ABdhPJyHn5twU4LkZcoYKuCxoR8tcb+N/bkXKneHFPW4m4dbsRJDdPzrjs8HKSuYVdqS41UFEMfXTQ== X-Received: by 2002:a63:ff66:: with SMTP id s38mr7901588pgk.154.1618941375116; Tue, 20 Apr 2021 10:56:15 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id t23sm2992047pju.15.2021.04.20.10.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 10:56:14 -0700 (PDT) Date: Tue, 20 Apr 2021 10:56:05 -0700 From: Stephen Hemminger To: Li Zhang Cc: dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com, lironh@marvell.com, jasvinder.singh@intel.com, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Cristian Dumitrescu , dev@dpdk.org, rasland@nvidia.com, roniba@nvidia.com Message-ID: <20210420105605.12429b88@hermes.local> In-Reply-To: <20210318085815.804896-1-lizh@nvidia.com> References: <20210318085815.804896-1-lizh@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 18 Mar 2021 10:58:14 +0200 Li Zhang wrote: > + > + /** > + * Color the packet to reflect the meter color result. > + * > + * See struct rte_flow_action_color. > + */ > + RTE_FLOW_ACTION_TYPE_COlOR, Why the odd use of lower case here? Shouldn't it be RTE_FLOW_ACTION_TYPE_COLOR