From: Kevin Traynor <ktraynor@redhat.com>
To: dev@dpdk.org
Cc: Kevin Traynor <ktraynor@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning
Date: Tue, 20 Apr 2021 14:09:14 +0100 [thread overview]
Message-ID: <20210420130915.166692-1-ktraynor@redhat.com> (raw)
clang 12 gives a warning about string size. In this case it looks like
it was unintentional to concatenate the strings. Separate with a comma.
$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
[2557/2719]
Compiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o
../app/test/test_cmdline_ipaddr.c:259:3: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"random invalid text",
^
../app/test/test_cmdline_ipaddr.c:258:3: note:
place parentheses around the string literal to silence warning
"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
^
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test/test_cmdline_ipaddr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c
index b3f50d80d2..2a1ee120fc 100644
--- a/app/test/test_cmdline_ipaddr.c
+++ b/app/test/test_cmdline_ipaddr.c
@@ -256,5 +256,5 @@ const char * ipaddr_invalid_strs[] = {
/* too long */
- "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
+ "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234",
"random invalid text",
"",
--
2.30.2
next reply other threads:[~2021-04-20 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 13:09 Kevin Traynor [this message]
2021-04-20 13:09 ` [dpdk-dev] [PATCH 2/2] app/test: silence " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 1/2] app/test: fix " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 2/2] app/test: silence " Kevin Traynor
2021-04-20 22:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420130915.166692-1-ktraynor@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).