DPDK patches and discussions
 help / color / mirror / Atom feed
From: Savinay Dharmappa <savinay.dharmappa@intel.com>
To: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com
Cc: savinay.dharmappa@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter
Date: Wed, 21 Apr 2021 07:50:01 +0100	[thread overview]
Message-ID: <20210421065001.96074-1-savinay.dharmappa@intel.com> (raw)
In-Reply-To: <20210309161002.31384-1-savinay.dharmappa@intel.com>

This patch fixes the traffic class oversubscription watermark
value by initialising it with computed value of maximum watermark.

Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
Cc: stable@dpdk.org

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
v3: update the title. 
---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 7c56880681..cd87e688e4 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		/* TC oversubscription */
 		s->tc_ov_wm_min = port->mtu;
-		s->tc_ov_wm = s->tc_ov_wm_max;
 		s->tc_ov_period_id = 0;
 		s->tc_ov = 0;
 		s->tc_ov_n = 0;
@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile->tc_period,
 							s->pipe_tc_be_rate_max);
+		s->tc_ov_wm = s->tc_ov_wm_max;
 #endif
 		s->profile = subport_profile_id;
 
-- 
2.17.1


  parent reply	other threads:[~2021-04-21  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 16:01 [dpdk-dev] [PATCH v1] sched : Initialize tc ov watermark Savinay Dharmappa
2021-03-09 16:10 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2021-03-10 16:53   ` Singh, Jasvinder
2021-03-15 16:42   ` Coyle, David
2021-03-23 16:02   ` Thomas Monjalon
2021-04-20 10:13     ` Thomas Monjalon
2021-04-20 10:36       ` Singh, Jasvinder
2021-04-20 13:54         ` Thomas Monjalon
2021-04-21  6:50   ` Savinay Dharmappa [this message]
2021-04-21 14:53     ` [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter Thomas Monjalon
2021-04-21 15:24     ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210421065001.96074-1-savinay.dharmappa@intel.com \
    --to=savinay.dharmappa@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).