From: Reshma Pattan <reshma.pattan@intel.com>
To: dev@dpdk.org
Cc: Reshma Pattan <reshma.pattan@intel.com>,
david.hunt@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check
Date: Wed, 21 Apr 2021 11:45:34 +0100 [thread overview]
Message-ID: <20210421104534.17768-1-reshma.pattan@intel.com> (raw)
VM channel number should not be validated against the
host vm_power_manager coremask core indexes, as VM
cores need not to be same as host cores.
So remove this check, to allow all the vm channels
to be added successfully.
Fixes: b49c677a0d24 ("examples/vm_power: respect core mask")
Cc: david.hunt@intel.com
Cc: stable@dpdk.org
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
examples/vm_power_manager/channel_manager.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
index 458e37167..fe9156785 100644
--- a/examples/vm_power_manager/channel_manager.c
+++ b/examples/vm_power_manager/channel_manager.c
@@ -454,9 +454,6 @@ add_all_channels(const char *vm_name)
CHANNEL_MGR_SOCKET_PATH, dir->d_name);
continue;
}
- if (rte_lcore_index(channel_num) == -1)
- continue;
-
/* if channel has not been added previously */
if (channel_exists(vm_info, channel_num))
continue;
@@ -514,9 +511,6 @@ add_channels(const char *vm_name, unsigned *channel_list,
}
for (i = 0; i < len_channel_list; i++) {
- if (rte_lcore_index(i) == -1)
- continue;
-
if (channel_list[i] >= RTE_MAX_LCORE) {
RTE_LOG(INFO, CHANNEL_MANAGER, "Channel(%u) is out of range "
"0...%d\n", channel_list[i],
--
2.17.1
next reply other threads:[~2021-04-21 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 10:45 Reshma Pattan [this message]
2021-04-23 8:56 ` David Hunt
2021-05-05 21:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421104534.17768-1-reshma.pattan@intel.com \
--to=reshma.pattan@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).