Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

2021-04-21 00:20 (UTC+0200), Thomas Monjalon:
> > Dmitry Kozlyuk (3):
> >   eal/windows: add timespec_get shim for MinGW
> >   net/pcap: move OS-dependent code to separate files
> >   net/pcap: build on Windows  
> 
> Compilation is failing on FreeBSD 11:
> http://mails.dpdk.org/archives/test-report/2021-April/188997.html
> 	implicit declaration of function 'timespec_get' is invalid in C99
> 	use of undeclared identifier 'TIME_UTC'
> 
> It should be fixed by including time.h 

No, FreeBSD 11 is missing timespec_get indeed.

> I cannot reproduce the issue with FreeBSD 12.

After adding a FreeBSD 11 shim and rebasing over "main"
I get another error unrelated to the patch.
It seems FreeBSD 11 is missing pthread_setname_np() as well.

[11/1847] Compiling C object lib/librte_telemetry.a.p/telemetry_telemetry.c.o
../src/lib/telemetry/telemetry.c:445:2: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]
        pthread_setname_np(t_old, "telemetry-v1");
        ^
../src/lib/telemetry/telemetry.c:474:2: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]
        pthread_setname_np(t_new, "telemetry-v2");
        ^
2 warnings generated.
[60/1847] Linking target lib/librte_telemetry.so.21.2
FAILED: lib/librte_telemetry.so.21.2 
cc  -o lib/librte_telemetry.so.21.2 lib/librte_telemetry.a.p/telemetry_telemetry.c.o lib/librte_telemetry.a.p/telemetry_telemetry_data.c.o lib/librte_telemetry.a.p/telemetry_telemetry_legacy.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_telemetry.so.21 -Wl,--no-as-needed -pthread -lm -lexecinfo -Wl,--end-group -Wl,--version-script=/tmp/src/lib/telemetry/version.map
lib/librte_telemetry.a.p/telemetry_telemetry.c.o: In function `rte_telemetry_init':
telemetry.c:(.text.internal+0x15a): undefined reference to `pthread_setname_np'
telemetry.c:(.text.internal+0x24d): undefined reference to `pthread_setname_np'
cc: error: linker command failed with exit code 1 (use -v to see invocation)