From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02BBDA0548; Thu, 22 Apr 2021 17:20:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB3DC41DAE; Thu, 22 Apr 2021 17:20:56 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 2683D41C9D for ; Thu, 22 Apr 2021 17:20:55 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id j14-20020a17090a694eb0290152d92c205dso1157143pjm.0 for ; Thu, 22 Apr 2021 08:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q6YV94eyaWJ1nQcUKPPRK6sIzeJwOQpxWscX76uKMfk=; b=EyAla4Nocr2exfxUhgHNtLAijznIY3ZLiF9zH6Tfdyx0ApTA5tJnJGyCOobOKH55vj v7uq7vYAaj7Dzc2oIA9oEK24pP3Vz0Mlmo7LbGYvpJaz9o3iJe/39a+1bysy4iMdm9lq kCw1c8g7ZpSdOLOM7hYu2+2RuOtdJZWWrT+oBUnkctYMGoww8yBi3tm9mcLPkYARLQLz LFYOMs193vQsPw7oUME5yvV8d6SAwQlG5dCrRpYgbtFfykLOLSBs9DyqvjL5mnrvEHfH oO+wGXiXIusmLj+SkaWrSebsbSTwtQrywTWeoDCDz6RfOkORpBc4MSTmVoqDk4noU8rF 0VLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q6YV94eyaWJ1nQcUKPPRK6sIzeJwOQpxWscX76uKMfk=; b=TYLi7+481ykbAxRpXHbGEMm/+/P9xCHNHNJJxkA3J2iseEhyQpsqA0LoRY98ioqBul JSIyTO54r92WZS/xkq01HAT6YryKv4AKseVJr67z8VizUTGwjBZ/T93pSw+BFjRP+IuZ kgGJ1552Zk7X8iaLNB7b+CMF0CsIaYQ/uGO9bptSHgZD7D4UvLQZKGnh1QR3hz5ruZ01 X9Ar6p+xCYIFa2QF5QzH0aYUIy9OMFOIyxPMYeQQGiSJcYgJZBRJ/yiGmmyqmieh4EjI HryPZZFo3RyunbuYiXQ57LcKAZCy1wRyHNnZfhzUQ7gGCVtTgAr7LvebJ5QiUaHDMhdH yRIA== X-Gm-Message-State: AOAM5302LI6ttjNegjYqX+F+2XMQQEJn63kMhgOI9BY639WiJq1oVi6n 1vJSngJmYqaBqROJLGDi/WomwQ== X-Google-Smtp-Source: ABdhPJx2+C3LeSo8+3zUmL1ILoOLCdpF9kBRFLtoaODFjgdPxg9gZUHnexVaWIDuH3rkFJWVUdo8rA== X-Received: by 2002:a17:90b:1bd0:: with SMTP id oa16mr4522185pjb.49.1619104854231; Thu, 22 Apr 2021 08:20:54 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id o127sm2518162pfd.147.2021.04.22.08.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Apr 2021 08:20:53 -0700 (PDT) Date: Thu, 22 Apr 2021 08:20:45 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: , , Message-ID: <20210422082045.35db7756@hermes.local> In-Reply-To: <1619090834-14643-3-git-send-email-humin29@huawei.com> References: <1619090834-14643-1-git-send-email-humin29@huawei.com> <1619090834-14643-3-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: fix tap interrupt vector array size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 22 Apr 2021 19:27:14 +0800 "Min Hu (Connor)" wrote: > diff --git a/drivers/net/tap/tap_intr.c b/drivers/net/tap/tap_intr.c > index 5cf4f17..1cacc15 100644 > --- a/drivers/net/tap/tap_intr.c > +++ b/drivers/net/tap/tap_intr.c > @@ -59,7 +59,7 @@ tap_rx_intr_vec_install(struct rte_eth_dev *dev) > > if (!dev->data->dev_conf.intr_conf.rxq) > return 0; > - intr_handle->intr_vec = malloc(sizeof(intr_handle->intr_vec[rxqs_n])); > + intr_handle->intr_vec = malloc(sizeof(int) * rxqs_n); Maybe calloc() here would be good idea?