* [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
@ 2021-04-23 5:22 Kalesh A P
2021-04-24 19:23 ` Ajit Khaparde
2021-04-28 15:48 ` Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Kalesh A P @ 2021-04-23 5:22 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Remove "__rte_unused" instances that are wrongly marked.
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_reps.c | 4 ++--
drivers/net/bnxt/bnxt_stats.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
index b224a7d..bdbad53 100644
--- a/drivers/net/bnxt/bnxt_reps.c
+++ b/drivers/net/bnxt/bnxt_reps.c
@@ -104,7 +104,7 @@ bnxt_rep_rx_burst(void *rx_queue,
static uint16_t
bnxt_rep_tx_burst(void *tx_queue,
struct rte_mbuf **tx_pkts,
- __rte_unused uint16_t nb_pkts)
+ uint16_t nb_pkts)
{
struct bnxt_vf_rep_tx_queue *vfr_txq = tx_queue;
struct bnxt_tx_queue *ptxq;
@@ -548,7 +548,7 @@ int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev,
return 0;
}
-int bnxt_rep_dev_configure_op(__rte_unused struct rte_eth_dev *eth_dev)
+int bnxt_rep_dev_configure_op(struct rte_eth_dev *eth_dev)
{
struct bnxt_representor *rep_bp = eth_dev->data->dev_private;
diff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h
index 0ee2269..ee6b1be 100644
--- a/drivers/net/bnxt/bnxt_stats.h
+++ b/drivers/net/bnxt/bnxt_stats.h
@@ -12,7 +12,7 @@ void bnxt_free_stats(struct bnxt *bp);
int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
struct rte_eth_stats *bnxt_stats);
int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev);
-int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
+int bnxt_dev_xstats_get_names_op(struct rte_eth_dev *eth_dev,
struct rte_eth_xstat_name *xstats_names,
__rte_unused unsigned int limit);
int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
--
2.10.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
2021-04-23 5:22 [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute Kalesh A P
@ 2021-04-24 19:23 ` Ajit Khaparde
2021-04-28 15:48 ` Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: Ajit Khaparde @ 2021-04-24 19:23 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]
On Thu, Apr 22, 2021 at 10:00 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Remove "__rte_unused" instances that are wrongly marked.
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_reps.c | 4 ++--
> drivers/net/bnxt/bnxt_stats.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
> index b224a7d..bdbad53 100644
> --- a/drivers/net/bnxt/bnxt_reps.c
> +++ b/drivers/net/bnxt/bnxt_reps.c
> @@ -104,7 +104,7 @@ bnxt_rep_rx_burst(void *rx_queue,
> static uint16_t
> bnxt_rep_tx_burst(void *tx_queue,
> struct rte_mbuf **tx_pkts,
> - __rte_unused uint16_t nb_pkts)
> + uint16_t nb_pkts)
> {
> struct bnxt_vf_rep_tx_queue *vfr_txq = tx_queue;
> struct bnxt_tx_queue *ptxq;
> @@ -548,7 +548,7 @@ int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev,
> return 0;
> }
>
> -int bnxt_rep_dev_configure_op(__rte_unused struct rte_eth_dev *eth_dev)
> +int bnxt_rep_dev_configure_op(struct rte_eth_dev *eth_dev)
> {
> struct bnxt_representor *rep_bp = eth_dev->data->dev_private;
>
> diff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h
> index 0ee2269..ee6b1be 100644
> --- a/drivers/net/bnxt/bnxt_stats.h
> +++ b/drivers/net/bnxt/bnxt_stats.h
> @@ -12,7 +12,7 @@ void bnxt_free_stats(struct bnxt *bp);
> int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
> struct rte_eth_stats *bnxt_stats);
> int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev);
> -int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
> +int bnxt_dev_xstats_get_names_op(struct rte_eth_dev *eth_dev,
> struct rte_eth_xstat_name *xstats_names,
> __rte_unused unsigned int limit);
> int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
> --
> 2.10.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
2021-04-23 5:22 [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute Kalesh A P
2021-04-24 19:23 ` Ajit Khaparde
@ 2021-04-28 15:48 ` Ferruh Yigit
2021-04-29 4:20 ` Kalesh Anakkur Purayil
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-04-28 15:48 UTC (permalink / raw)
To: Kalesh A P, dev; +Cc: ajit.khaparde
On 4/23/2021 6:22 AM, Kalesh A P wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Remove "__rte_unused" instances that are wrongly marked.
>
Can you please provide the fixes tags, so that patch can be backported to
required stable versions?
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
<...>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
2021-04-28 15:48 ` Ferruh Yigit
@ 2021-04-29 4:20 ` Kalesh Anakkur Purayil
2021-04-29 11:08 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Kalesh Anakkur Purayil @ 2021-04-29 4:20 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dpdk-dev, Ajit Kumar Khaparde
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
Hi Ferruh,
On Wed, Apr 28, 2021 at 9:18 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 4/23/2021 6:22 AM, Kalesh A P wrote:
> > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> >
> > Remove "__rte_unused" instances that are wrongly marked.
> >
>
> Can you please provide the fixes tags, so that patch can be backported to
> required stable versions?
>
[Kalesh]: I was not sure whether it qualifies as a fix. That's why I didn't
add it in the first place.
Below is the fixes tags:
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in
reset")
Cc: stable@dpdk.org
Do you want me to send a new version?
Regards,
Kalesh
>
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> <...>
>
--
Regards,
Kalesh A P
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
2021-04-29 4:20 ` Kalesh Anakkur Purayil
@ 2021-04-29 11:08 ` Ferruh Yigit
2021-04-29 11:37 ` Kalesh Anakkur Purayil
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-04-29 11:08 UTC (permalink / raw)
To: Kalesh Anakkur Purayil; +Cc: dpdk-dev, Ajit Kumar Khaparde
On 4/29/2021 5:20 AM, Kalesh Anakkur Purayil wrote:
> Hi Ferruh,
>
> On Wed, Apr 28, 2021 at 9:18 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
>
> On 4/23/2021 6:22 AM, Kalesh A P wrote:
> > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
> <mailto:kalesh-anakkur.purayil@broadcom.com>>
> >
> > Remove "__rte_unused" instances that are wrongly marked.
> >
>
> Can you please provide the fixes tags, so that patch can be backported to
> required stable versions?
>
> [Kalesh]: I was not sure whether it qualifies as a fix. That's why I didn't add
> it in the first place.
> Below is the fixes tags:
>
> Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in reset")
> Cc: stable@dpdk.org <mailto:stable@dpdk.org>
>
> Do you want me to send a new version?
>
No, above is good enough, I can add them in repo. Thanks.
> Regards,
> Kalesh
>
>
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
> <mailto:kalesh-anakkur.purayil@broadcom.com>>
> > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com
> <mailto:ajit.khaparde@broadcom.com>>
>
> <...>
>
>
>
> --
> Regards,
> Kalesh A P
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
2021-04-29 11:08 ` Ferruh Yigit
@ 2021-04-29 11:37 ` Kalesh Anakkur Purayil
0 siblings, 0 replies; 6+ messages in thread
From: Kalesh Anakkur Purayil @ 2021-04-29 11:37 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dpdk-dev, Ajit Kumar Khaparde
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
On Thu, Apr 29, 2021 at 4:38 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 4/29/2021 5:20 AM, Kalesh Anakkur Purayil wrote:
> > Hi Ferruh,
> >
> > On Wed, Apr 28, 2021 at 9:18 PM Ferruh Yigit <ferruh.yigit@intel.com
> > <mailto:ferruh.yigit@intel.com>> wrote:
> >
> > On 4/23/2021 6:22 AM, Kalesh A P wrote:
> > > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
> > <mailto:kalesh-anakkur.purayil@broadcom.com>>
> > >
> > > Remove "__rte_unused" instances that are wrongly marked.
> > >
> >
> > Can you please provide the fixes tags, so that patch can be
> backported to
> > required stable versions?
> >
> > [Kalesh]: I was not sure whether it qualifies as a fix. That's why I
> didn't add
> > it in the first place.
> > Below is the fixes tags:
> >
> > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> > Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in
> reset")
> > Cc: stable@dpdk.org <mailto:stable@dpdk.org>
> >
> > Do you want me to send a new version?
> >
>
> No, above is good enough, I can add them in repo. Thanks.
>
[Kalesh]: Thank you Ferruh.
>
> > Regards,
> > Kalesh
> >
> >
> > > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
> > <mailto:kalesh-anakkur.purayil@broadcom.com>>
> > > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com
> > <mailto:somnath.kotur@broadcom.com>>
> > > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com
> > <mailto:ajit.khaparde@broadcom.com>>
> >
> > <...>
> >
> >
> >
> > --
> > Regards,
> > Kalesh A P
>
>
--
Regards,
Kalesh A P
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-29 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 5:22 [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute Kalesh A P
2021-04-24 19:23 ` Ajit Khaparde
2021-04-28 15:48 ` Ferruh Yigit
2021-04-29 4:20 ` Kalesh Anakkur Purayil
2021-04-29 11:08 ` Ferruh Yigit
2021-04-29 11:37 ` Kalesh Anakkur Purayil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).