From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EFD9A0547; Sat, 24 Apr 2021 02:53:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEBE240141; Sat, 24 Apr 2021 02:53:56 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 2AE8B40041; Sat, 24 Apr 2021 02:53:55 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id 5619020B8001; Fri, 23 Apr 2021 17:53:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5619020B8001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1619225634; bh=JKQOhEbd9sKw3Z9QPR4Qpghozod5t9e8cqwzRWLWTkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TgEscBadoT+ya7/3vbC5SEW98x+YRUPDk7oAZR0OXSj54J29OR9+Rl1E9nshe1bC6 84ZrahMaOYxvV4d+9uGDseCXEFAtPni4RvoCaZ80xukpXXvzCvL6iEQkm7ufX39ut8 01Jmt5BIy3Oild7dFVfpMgSrpsWuo7K3YSPPuO+U= Date: Fri, 23 Apr 2021 17:53:54 -0700 From: Narcisa Ana Maria Vasile To: Nick Connolly Cc: Bruce Richardson , Ranjit Menon , dev@dpdk.org, dmitry.kozliuk@gmail.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, stable@dpdk.org Message-ID: <20210424005354.GA2117@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210401122723.23082-1-nick.connolly@mayadata.io> <20210410080143.21279-1-nick.connolly@mayadata.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210410080143.21279-1-nick.connolly@mayadata.io> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2] build: fix symlink of drivers for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 10, 2021 at 09:01:43AM +0100, Nick Connolly wrote: > The symlink-drivers-solibs.sh script was disabled as part of 'install' > for Windows because there is no support for shell scripts. However, > this means that driver related DLLs are not present in the installed > 'libdir' directory. Add a python script to perform the install and use > it for Windows if the version of meson supports using an external > program with add_install_script (>= 0.55.0). > > On Windows, symbolic links are somewhat problematic since the > SeCreateSymbolicLinkPrivilege is required to be able to create them. > In addition, different cross-compilation environments handle symbolic > links differently, e.g. WSL, Msys2, Cygwin. Rather than trying to > distinguish these scenarios, the python script will perform a file copy > for any Windows specific names. > > On Windows, the shared library outputs have different names depending > upon which toolset has been used to build them. The script currently > handles Clang and GCC. > > On Linux the functionality is unchanged, but could be replaced with the > python script once the required minimum version of meson is >= 0.55.0. > > Fixes: 5c7d86948764 ("build: fix install on Windows") > Cc: stable@dpdk.org > > Signed-off-by: Nick Connolly > --- > buildtools/symlink-drivers-solibs.py | 49 ++++++++++++++++++++++++++++ > config/meson.build | 4 +++ > 2 files changed, 53 insertions(+) > create mode 100644 buildtools/symlink-drivers-solibs.py > > diff --git a/buildtools/symlink-drivers-solibs.py b/buildtools/symlink-drivers-solibs.py Tested-by: Narcisa Vasile Acked-by: Narcisa Vasile Note that it needs rebasing.