DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] fix missing set primary mac type when start port
@ 2021-04-27  9:22 Robin Zhang
  2021-04-27  9:22 ` [dpdk-dev] [PATCH 1/2] net/iavf: " Robin Zhang
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Robin Zhang @ 2021-04-27  9:22 UTC (permalink / raw)
  To: dev
  Cc: beilei.xing, jia.guo, jingjing.wu, qiming.yang, stevex.yang, Robin Zhang

When start port, all mac addresses will be set. We should set the mac
type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.

Robin Zhang (2):
  net/iavf: fix missing set primary mac type when start port
  net/i40e: fix missing set primary mac type when start port

 drivers/net/i40e/i40e_ethdev_vf.c | 4 +++-
 drivers/net/iavf/iavf_vchnl.c     | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH 1/2] net/iavf: fix missing set primary mac type when start port
  2021-04-27  9:22 [dpdk-dev] [PATCH 0/2] fix missing set primary mac type when start port Robin Zhang
@ 2021-04-27  9:22 ` Robin Zhang
  2021-04-28  7:45   ` Yang, Qiming
  2021-04-27  9:22 ` [dpdk-dev] [PATCH 2/2] net/i40e: " Robin Zhang
  2021-04-28  8:04 ` [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC " Robin Zhang
  2 siblings, 1 reply; 8+ messages in thread
From: Robin Zhang @ 2021-04-27  9:22 UTC (permalink / raw)
  To: dev
  Cc: beilei.xing, jia.guo, jingjing.wu, qiming.yang, stevex.yang, Robin Zhang

When start port, all mac addresses will be set. We should set the mac
type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.

Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
 drivers/net/iavf/iavf_vchnl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 0026120cf4..5d57e8b541 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add)
 				continue;
 			rte_memcpy(list->list[j].addr, addr->addr_bytes,
 				   sizeof(addr->addr_bytes));
-			list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA;
+			list->list[j].type = (j == 0 ?
+					      VIRTCHNL_ETHER_ADDR_PRIMARY :
+					      VIRTCHNL_ETHER_ADDR_EXTRA);
 			PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
 				    addr->addr_bytes[0], addr->addr_bytes[1],
 				    addr->addr_bytes[2], addr->addr_bytes[3],
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH 2/2] net/i40e: fix missing set primary mac type when start port
  2021-04-27  9:22 [dpdk-dev] [PATCH 0/2] fix missing set primary mac type when start port Robin Zhang
  2021-04-27  9:22 ` [dpdk-dev] [PATCH 1/2] net/iavf: " Robin Zhang
@ 2021-04-27  9:22 ` Robin Zhang
  2021-04-28  8:04 ` [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC " Robin Zhang
  2 siblings, 0 replies; 8+ messages in thread
From: Robin Zhang @ 2021-04-27  9:22 UTC (permalink / raw)
  To: dev
  Cc: beilei.xing, jia.guo, jingjing.wu, qiming.yang, stevex.yang, Robin Zhang

When start port, all mac addresses will be set. We should set the mac
type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.

Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address")

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index aeb6816b9f..8f3b152b6c 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2127,7 +2127,9 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
 				continue;
 			rte_memcpy(list->list[j].addr, addr->addr_bytes,
 					 sizeof(addr->addr_bytes));
-			list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA;
+			list->list[j].type = (j == 0 ?
+					      VIRTCHNL_ETHER_ADDR_PRIMARY :
+					      VIRTCHNL_ETHER_ADDR_EXTRA);
 			PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
 				    addr->addr_bytes[0], addr->addr_bytes[1],
 				    addr->addr_bytes[2], addr->addr_bytes[3],
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] net/iavf: fix missing set primary mac type when start port
  2021-04-27  9:22 ` [dpdk-dev] [PATCH 1/2] net/iavf: " Robin Zhang
@ 2021-04-28  7:45   ` Yang, Qiming
  0 siblings, 0 replies; 8+ messages in thread
From: Yang, Qiming @ 2021-04-28  7:45 UTC (permalink / raw)
  To: Zhang, RobinX, dev; +Cc: Xing, Beilei, Guo, Jia, Wu, Jingjing, Yang, SteveX

Hi, 

> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Tuesday, April 27, 2021 17:23
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX
> <robinx.zhang@intel.com>
> Subject: [PATCH 1/2] net/iavf: fix missing set primary mac type when start
> port
> 
> When start port, all mac addresses will be set. We should set the mac type of

Please use MAC.

> default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
> 
> Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
> ---
>  drivers/net/iavf/iavf_vchnl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 0026120cf4..5d57e8b541 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter
> *adapter, bool add)
>  				continue;
>  			rte_memcpy(list->list[j].addr, addr->addr_bytes,
>  				   sizeof(addr->addr_bytes));
> -			list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA;
> +			list->list[j].type = (j == 0 ?
> +
> VIRTCHNL_ETHER_ADDR_PRIMARY :
> +					      VIRTCHNL_ETHER_ADDR_EXTRA);
>  			PMD_DRV_LOG(DEBUG, "add/rm
> mac:%x:%x:%x:%x:%x:%x",
>  				    addr->addr_bytes[0], addr-
> >addr_bytes[1],
>  				    addr->addr_bytes[2], addr-
> >addr_bytes[3],
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC type when start port
  2021-04-27  9:22 [dpdk-dev] [PATCH 0/2] fix missing set primary mac type when start port Robin Zhang
  2021-04-27  9:22 ` [dpdk-dev] [PATCH 1/2] net/iavf: " Robin Zhang
  2021-04-27  9:22 ` [dpdk-dev] [PATCH 2/2] net/i40e: " Robin Zhang
@ 2021-04-28  8:04 ` Robin Zhang
  2021-04-28  8:04   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: " Robin Zhang
  2021-04-29  8:35   ` [dpdk-dev] [PATCH v2 1/2] net/iavf: " Zhang, Qi Z
  2 siblings, 2 replies; 8+ messages in thread
From: Robin Zhang @ 2021-04-28  8:04 UTC (permalink / raw)
  To: dev; +Cc: beilei.xing, jia.guo, qiming.yang, stevex.yang, Robin Zhang

When start port, all MAC addresses will be set. We should set the MAC
type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.

Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
v2:
-fix commit message typo
---
 drivers/net/iavf/iavf_vchnl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 0026120cf4..5d57e8b541 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add)
 				continue;
 			rte_memcpy(list->list[j].addr, addr->addr_bytes,
 				   sizeof(addr->addr_bytes));
-			list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA;
+			list->list[j].type = (j == 0 ?
+					      VIRTCHNL_ETHER_ADDR_PRIMARY :
+					      VIRTCHNL_ETHER_ADDR_EXTRA);
 			PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
 				    addr->addr_bytes[0], addr->addr_bytes[1],
 				    addr->addr_bytes[2], addr->addr_bytes[3],
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2 2/2] net/i40e: fix missing set primary MAC type when start port
  2021-04-28  8:04 ` [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC " Robin Zhang
@ 2021-04-28  8:04   ` Robin Zhang
  2021-04-29  8:35     ` Zhang, Qi Z
  2021-04-29  8:35   ` [dpdk-dev] [PATCH v2 1/2] net/iavf: " Zhang, Qi Z
  1 sibling, 1 reply; 8+ messages in thread
From: Robin Zhang @ 2021-04-28  8:04 UTC (permalink / raw)
  To: dev; +Cc: beilei.xing, jia.guo, qiming.yang, stevex.yang, Robin Zhang

When start port, all MAC addresses will be set. We should set the MAC
type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.

Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address")

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
v2:
-fix commit message typo
---
 drivers/net/i40e/i40e_ethdev_vf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index aeb6816b9f..8f3b152b6c 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2127,7 +2127,9 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
 				continue;
 			rte_memcpy(list->list[j].addr, addr->addr_bytes,
 					 sizeof(addr->addr_bytes));
-			list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA;
+			list->list[j].type = (j == 0 ?
+					      VIRTCHNL_ETHER_ADDR_PRIMARY :
+					      VIRTCHNL_ETHER_ADDR_EXTRA);
 			PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
 				    addr->addr_bytes[0], addr->addr_bytes[1],
 				    addr->addr_bytes[2], addr->addr_bytes[3],
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC type when start port
  2021-04-28  8:04 ` [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC " Robin Zhang
  2021-04-28  8:04   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: " Robin Zhang
@ 2021-04-29  8:35   ` Zhang, Qi Z
  1 sibling, 0 replies; 8+ messages in thread
From: Zhang, Qi Z @ 2021-04-29  8:35 UTC (permalink / raw)
  To: Zhang, RobinX, dev
  Cc: Xing, Beilei, Guo, Jia, Yang, Qiming, Yang, SteveX, Zhang, RobinX



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Robin Zhang
> Sent: Wednesday, April 28, 2021 4:05 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>;
> Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC type
> when start port
> 
> When start port, all MAC addresses will be set. We should set the MAC type of
> default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
> 
> Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix missing set primary MAC type when start port
  2021-04-28  8:04   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: " Robin Zhang
@ 2021-04-29  8:35     ` Zhang, Qi Z
  0 siblings, 0 replies; 8+ messages in thread
From: Zhang, Qi Z @ 2021-04-29  8:35 UTC (permalink / raw)
  To: Zhang, RobinX, dev
  Cc: Xing, Beilei, Guo, Jia, Yang, Qiming, Yang, SteveX, Zhang, RobinX



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Robin Zhang
> Sent: Wednesday, April 28, 2021 4:05 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>;
> Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix missing set primary MAC type
> when start port
> 
> When start port, all MAC addresses will be set. We should set the MAC type of
> default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
> 
> Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address")
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-04-29  8:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27  9:22 [dpdk-dev] [PATCH 0/2] fix missing set primary mac type when start port Robin Zhang
2021-04-27  9:22 ` [dpdk-dev] [PATCH 1/2] net/iavf: " Robin Zhang
2021-04-28  7:45   ` Yang, Qiming
2021-04-27  9:22 ` [dpdk-dev] [PATCH 2/2] net/i40e: " Robin Zhang
2021-04-28  8:04 ` [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC " Robin Zhang
2021-04-28  8:04   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: " Robin Zhang
2021-04-29  8:35     ` Zhang, Qi Z
2021-04-29  8:35   ` [dpdk-dev] [PATCH v2 1/2] net/iavf: " Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git