From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FE5DA0547; Thu, 29 Apr 2021 19:09:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 059CB410F1; Thu, 29 Apr 2021 19:09:18 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 9856B410DD for ; Thu, 29 Apr 2021 19:09:16 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id B998F20B8000; Thu, 29 Apr 2021 10:09:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B998F20B8000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1619716155; bh=Jd4VLH6eaN7MzqG12UnwfvQspF2AcXWDUr1sYP0O0r0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YFL8HQH9w9IXAbezv2cmsekChjPohmd/p+g2ivfXHGb9q9wWLTv/GLmoriJay/MzN HnoXFHKg6bOMQIj4GV+aurJhAlzt16HQtyjawgrKAFzGpQCfQolQi3qFUt/oe5O7GF mxqAOQ7lOXVUTjKJ4CrYjyhN2JzqsGDPDKQcQ8Oc= Date: Thu, 29 Apr 2021 10:09:15 -0700 From: Tyler Retzlaff To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: Dmitry Kozlyuk , dev@dpdk.org, Jie Zhou , Nick Connolly , Khoa To , Ray Kinsella , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Neil Horman Message-ID: <20210429170915.GD21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210320130525.16452-1-dmitry.kozliuk@gmail.com> <20210403234129.20296-1-dmitry.kozliuk@gmail.com> <20210403234129.20296-2-dmitry.kozliuk@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35C616C0@smartserver.smartshare.dk> <20210407022949.7dc80aa4@sovereign> <98CBD80474FA8B44BF855DF32C47DC35C616C2@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C616C2@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v7 1/5] eal: add sleep API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 07, 2021 at 09:31:43AM +0200, Morten Brørup wrote: > > I think it's just tradition from Linux/BSD developers not being used to cross-platform development or having forgotten how to develop software for deeply embedded systems without a standard O/S below. We use POSIX functions like sleep() without thinking about it, and simply forget looking for an EAL variant of the function first. > it's easy to make this mistake if by including dpdk application headers we indirectly introduce platform specific headers into the applications namespace. if this wasn't happening the application would be forced to confront the issue by directly including unistd.h itself directly making it more obvious that they were writing inherently non-portable code. i think this is being fixed but it is a work in progress but it highlights the reason why there needs to be scrutiny around what goes into the eal and other library headers.