From: Lingyu Liu <lingyu.liu@intel.com>
To: dev@dpdk.org
Cc: Lingyu Liu <lingyu.liu@intel.com>
Subject: [dpdk-dev] [PATCH v1] net/ixgbe: configure EXVET_T register
Date: Thu, 29 Apr 2021 18:23:43 +0000 [thread overview]
Message-ID: <20210429182343.52628-1-lingyu.liu@intel.com> (raw)
According to X550 datasheet (section 8.2.1.2), when setting vlan tpid,
the register EXVET_T on X550 NICs also need to be configured.
Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
---
drivers/net/ixgbe/base/ixgbe_type.h | 1 +
drivers/net/ixgbe/ixgbe_ethdev.c | 33 +++++++++++++++++++++++++++++
2 files changed, 34 insertions(+)
diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h
index bc927a3..8e22be7 100644
--- a/drivers/net/ixgbe/base/ixgbe_type.h
+++ b/drivers/net/ixgbe/base/ixgbe_type.h
@@ -151,6 +151,7 @@
#define IXGBE_TCPTIMER 0x0004C
#define IXGBE_CORESPARE 0x00600
#define IXGBE_EXVET 0x05078
+#define IXGBE_EXVET_T 0x08224
/* NVM Registers */
#define IXGBE_EEC 0x10010
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index dcd7291..b9c89e8 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1925,6 +1925,39 @@ ixgbe_vlan_tpid_set(struct rte_eth_dev *dev,
/* Only the high 16-bits is valid */
IXGBE_WRITE_REG(hw, IXGBE_EXVET, (uint32_t)tpid <<
IXGBE_EXVET_VET_EXT_SHIFT);
+ /* For X550, additional register need be set*/
+ switch (hw->device_id) {
+ case IXGBE_DEV_ID_X550T:
+ case IXGBE_DEV_ID_X550T1:
+ case IXGBE_DEV_ID_X550EM_A_KR:
+ case IXGBE_DEV_ID_X550EM_A_KR_L:
+ case IXGBE_DEV_ID_X550EM_A_SFP_N:
+ case IXGBE_DEV_ID_X550EM_A_SGMII:
+ case IXGBE_DEV_ID_X550EM_A_SGMII_L:
+ case IXGBE_DEV_ID_X550EM_A_10G_T:
+ case IXGBE_DEV_ID_X550EM_A_QSFP:
+ case IXGBE_DEV_ID_X550EM_A_QSFP_N:
+ case IXGBE_DEV_ID_X550EM_A_SFP:
+ case IXGBE_DEV_ID_X550EM_A_1G_T:
+ case IXGBE_DEV_ID_X550EM_A_1G_T_L:
+ case IXGBE_DEV_ID_X550EM_X_KX4:
+ case IXGBE_DEV_ID_X550EM_X_KR:
+ case IXGBE_DEV_ID_X550EM_X_SFP:
+ case IXGBE_DEV_ID_X550EM_X_10G_T:
+ case IXGBE_DEV_ID_X550EM_X_1G_T:
+ case IXGBE_DEV_ID_X550EM_X_XFI:
+ case IXGBE_DEV_ID_X550_VF_HV:
+ case IXGBE_DEV_ID_X550_VF:
+ case IXGBE_DEV_ID_X550EM_A_VF:
+ case IXGBE_DEV_ID_X550EM_A_VF_HV:
+ case IXGBE_DEV_ID_X550EM_X_VF:
+ case IXGBE_DEV_ID_X550EM_X_VF_HV:
+ IXGBE_WRITE_REG(hw, IXGBE_EXVET_T, (uint32_t)tpid <<
+ IXGBE_EXVET_VET_EXT_SHIFT);
+ break;
+ default:
+ break;
+ }
} else {
reg = IXGBE_READ_REG(hw, IXGBE_VLNCTRL);
reg = (reg & (~IXGBE_VLNCTRL_VET)) | (uint32_t)tpid;
--
2.25.1
next reply other threads:[~2021-04-29 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 18:23 Lingyu Liu [this message]
2021-05-08 1:57 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429182343.52628-1-lingyu.liu@intel.com \
--to=lingyu.liu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).