From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EF7DDA0547;
	Thu, 29 Apr 2021 21:04:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 67DE3410DF;
	Thu, 29 Apr 2021 21:04:01 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 70D91410DD
 for <dev@dpdk.org>; Thu, 29 Apr 2021 21:03:59 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 9B30720B8000; Thu, 29 Apr 2021 12:03:58 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9B30720B8000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1619723038;
 bh=hBz1Y+l7jtECYpw0xnezWtINZBxjBXaIp/L7GUXcAww=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=J+H5UKvQ3wxQOgNteohuro3DFR9C9Zdb3nxZNLfNH6Ycya9LFhQXBvcIKQSJPwxDT
 i4bOjgcU2T/+2Bj4JJFMFdjR5AXm3MlHpYS0E2JJEIKgNnf/Gsjpd+GJsh0YZ4klmh
 ZWsB4gi253mYVENyCwSVljtN3hbT4vLXPEu8nAcQ=
Date: Thu, 29 Apr 2021 12:03:58 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: thomas@monjalon.net, david.marchand@redhat.com,
 honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, dev@dpdk.org,
 nd@arm.com
Message-ID: <20210429190358.GG21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20210421071733.17794-1-joyce.kong@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210421071733.17794-1-joyce.kong@arm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins
 for lcores sync
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Apr 21, 2021 at 02:17:33AM -0500, Joyce Kong wrote:
> Convert rte_atomic usages to C11 atomic builtins for lcores sync
> in ticketlock testcases.

gcc atomic builtins aren't 'C11'

> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---

the change makes this code less portable to non-gcc emulating compilers.

please don't.