From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC13AA0546; Fri, 30 Apr 2021 14:58:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC0ED412B1; Fri, 30 Apr 2021 14:57:59 +0200 (CEST) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id C3CC8410D7 for ; Fri, 30 Apr 2021 14:57:52 +0200 (CEST) Received: by mail-wr1-f52.google.com with SMTP id z6so9196399wrm.4 for ; Fri, 30 Apr 2021 05:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GGtM5qsb7+GqyqX/GA3YsmYDNifrLD8/+HhQUhZLHtY=; b=qJiu21ZWrBydKTBJTh/zWyWmVTZTrAAzfcDHj15YgK4ADvJnw8+YKGmDbU4gBWfuT4 KVpbSEb1iwwl6of7ulRLr7s58HX259VKeaYBjceqrljWHK56DN8UGWwz4UAZep7tdApN eWNz8Sgc92XksLnEIIV0dyKRAY0pWWGtsiLfnb6yfEh3WE9eMOzk6BvTEY+GNTBnLBQE ZElHqMBOQhTOWO1DVnL23kBr8LlMbxRNjLLhZnCBoISO7ysAlj9d+tsjj61Y++9kF5l6 J/aADxofrH38GsQE3pphbxt3q0ZKUo2r8RuuTSoBOQ79/7UiHn5TSMvjJcoVHBSNH9Db +7sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GGtM5qsb7+GqyqX/GA3YsmYDNifrLD8/+HhQUhZLHtY=; b=FrpcmlYw7NAxcFY3XgePlfdsSNjjyID9NkfKoEykZqRVXVgyEd+z5N/QZn7JpF3IUO 0YS1QIt0WKqFgtt4J7rrKgb6VIEVKCR3SI2e7x5gYaxUyrkTX0YqGIH5P8FuqGCE2ogb L0qxa/HgiRhNH9QuwDx9PYswJbF5Kzp9/G7s8jkgvKyWm/X46voNOGvM9Pu2dinKhwzE dGX03wIDue3LxPTK1BPZkOEP5vO0TNjCSwhEAzcxvEGXq3yG3z27wBpTJk6UoHGcdesF RH+Uxzo+REE7+xPYORxNsFw5FQeVMIM7NDVe0+Rm4nmkZ0OwPknO4jtj9HA/I0PhPOJL u93w== X-Gm-Message-State: AOAM532zgfmfacnfVJmcqRm3DoCWY0XRbOjJPctHYzrouD/6YAMlyu7E vAeKaKRfuh7rxZtXP6Zc4A8LXA9l/tSjPX3K X-Google-Smtp-Source: ABdhPJyoJPTusYPKFi1bBy9yAFx2/IfHz5bcvWi1PQ0Ez7qilbIvoMBr9z/N5MwPzLL1mGSk+oAW0w== X-Received: by 2002:a5d:4145:: with SMTP id c5mr6746510wrq.252.1619787472261; Fri, 30 Apr 2021 05:57:52 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id l13sm13476245wmj.3.2021.04.30.05.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 05:57:51 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: ndagan@amazom.com, gtzalik@amazon.com, igorch@amazon.com, mw@semihalf.com, stable@dpdk.org, Shay Agroskin , Michal Krawczyk Date: Fri, 30 Apr 2021 14:57:15 +0200 Message-Id: <20210430125725.28796-13-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210430125725.28796-1-mk@semihalf.com> References: <20210430125725.28796-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 12/22] net/ena: fix parsing of large_llq_hdr argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Igor Chauskin The code incorrectly checked the return value of comparison when parsing the argument key name. The return value of strcmp should be compared to 0 to identify a match. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Shay Agroskin Reviewed-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3c9102cd19..cb8ad5c3d0 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2865,7 +2865,7 @@ static int ena_process_bool_devarg(const char *key, } /* Now, assign it to the proper adapter field. */ - if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR)) + if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR) == 0) adapter->use_large_llq_hdr = bool_value; return 0; -- 2.25.1