From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC27DA0546; Fri, 30 Apr 2021 14:59:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40D04412C7; Fri, 30 Apr 2021 14:58:01 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 2126F41153 for ; Fri, 30 Apr 2021 14:57:54 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id d4so2051413wru.7 for ; Fri, 30 Apr 2021 05:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ya29Y1oo4CSGqqdor+vF9iZ5PkFZCJ8mO7cQJ+GXFEQ=; b=lVGkyFy7JMhzugEm9TqG3dc3eflzQBHhtEn+RxVSozEyaHSusZ2z3LsZx60kmhHiGS FY3Ikwrk6j4TG6My9pZvT6oqi2yBHi5bUjKQORC3TupvkglXA3YXEPFMT1HK7ppGW78p +iI0ljJN5AmZQntS3Cxz2SrKmuavanBQ/fzfY0KKQEEH2ayZwGHIqgtCHGZGDGezJLeM t9y1DO0mjKCqFFmWl9ySsLYzpYoSsbefM+YUnEWCukVyjt1pypm8nldTQYNn9N+OYCCY Z7qLGGtpApCzpczxSFUHrHBFVFs1igfKan7Wz0ZQ/4OoXa7oAqiIL1jU/d7CMF5GGk+J O1+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ya29Y1oo4CSGqqdor+vF9iZ5PkFZCJ8mO7cQJ+GXFEQ=; b=ZXeQcALyFgDOpUNE+AYVL2xGb9hKxLe0qOng8M1atadu4VIWzPe3OzRD5IwGMLnyPn Jyfwn8cUf6anqlk4//cWEvGwKvaHrkqcXaeCeSOcpJH9lOmxhHi0sNriBuAE+hPcLE3F C4MOYlx5Op4HOyYYt2BpkC92ZGYbuQriCiEiP4uXWFh0gFIiWUY55TvI/GxPmdepNyDe sXg9OCEa0NICq5N/y39lOVqa6oOL7grmnf+KCK/z0nzUSVZ3f9LLvq7qwvuxBl72/k8t IZ99xC6mMz/FvydsQY47ywStVZoto6gVVJV521pyQ6fafSMmAMqbc2QF7kw6B193i1oU VMNg== X-Gm-Message-State: AOAM532Y7HgkxFnoAI1aBWjrBQLtbeP/Exf+OEI230EpKYY7hL39eljl 7+fxQaZdCwsfSCNHFX8v2yvGu6tvdB4eRQR2 X-Google-Smtp-Source: ABdhPJzFSB+gHnYBcOcTT8MW1v3XhNfp1TT9Omfl50p8BBPdYPqNPorH3bsb0XhyXsKW/LCiJK0YAA== X-Received: by 2002:adf:fa84:: with SMTP id h4mr6536323wrr.44.1619787473657; Fri, 30 Apr 2021 05:57:53 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id l13sm13476245wmj.3.2021.04.30.05.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 05:57:52 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: ndagan@amazom.com, gtzalik@amazon.com, igorch@amazon.com, mw@semihalf.com, Michal Krawczyk , stable@dpdk.org, Shay Agroskin Date: Fri, 30 Apr 2021 14:57:16 +0200 Message-Id: <20210430125725.28796-14-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210430125725.28796-1-mk@semihalf.com> References: <20210430125725.28796-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 13/22] net/ena: terminate devargs allowed keys with NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As the documentation of rte_kvargs_parse() states, the valid_keys argument must be NULL terminated. Lack of this feature may cause segmentation fault if the passed devarg will be different then the supported value. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroskin --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index cb8ad5c3d0..6092288239 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter, { static const char * const allowed_args[] = { ENA_DEVARG_LARGE_LLQ_HDR, + NULL, }; struct rte_kvargs *kvlist; int rc; -- 2.25.1