From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E2D7A0546; Fri, 30 Apr 2021 19:51:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E79C4014F; Fri, 30 Apr 2021 19:51:13 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id 66C9C4013F for ; Fri, 30 Apr 2021 19:51:12 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id 2so18621567lft.4 for ; Fri, 30 Apr 2021 10:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mP/YhcOOnGAM15ig+fniQcucd7wvWoKrRcApeGhTIew=; b=jsR0BaA3rWy9G2x6c19DbnE5oOp3/9AJ396tVQFdJmp7BBpZ5MhTUNV1mvAmVVqCrw MaXBQdYpnDPr00uEiW1gRnP9kBLxE6TNlVSEsUSC12kZmDp9uOG3iPqV1L0wlzDyRjIm 1TqwVY5EQBErqMwcBv+XnSXCouTDS1DXLRWDb6vysYUmDPzuE3Rblxzfb44G1BSg9O+7 5Y1pUvIP0d9bjnUuuO6j6XJEJMzHe+h/W2aANhpipx/CY7BAnILvZ7bkg9hNL0S2wlYY d9Xxx5ALhrrDSFGPTcZH2QCcFm6xSURF1Ck6XD+k3DIKJ0R6GJnEXfC/P/AUx5EwqXcE WkGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mP/YhcOOnGAM15ig+fniQcucd7wvWoKrRcApeGhTIew=; b=RiWGfZuXChtpsRGGSb9EnJdvHp1Faf7SdaB2dLA2FfpKc4Q8nsE5k0l2ycrdOMLudk rA/udh06wJPBE5koZkjZOwEoDTwfBgHXFcvHrKgMCRPuhaKw34SjMU/edSxNker7cnGM 7YnftI7Uv+W6TzA/RZXZeLinhfJiY+Pe8kDZaNf7P67CZxwYS/fBj6GRLOARhZQtNOv6 NRkoB5eNYAT+NmzoZQ5uQVaLZ0GWGkfQIJjp2ZQ6w4g6Id+cy0hI3D5rl9a58+7YOyiS 9D2Tdalo9VKYEHxU6+Eu/n0BAah7bJCkc/8v4SuSXZlv7O5eElysm8j+IeXAkiFsk0qz /fhQ== X-Gm-Message-State: AOAM533eioJ50oKDZPB3lZs0QumubFIrs0l4W1OnX22P7mHCEF3chMcJ VMrjzl8vTcphHd/nJm/dRPg= X-Google-Smtp-Source: ABdhPJyp9kQFTv9GDXu4nMB8YBsQYPOIFuLaqNfoJyJA8CR2rUmnhH9L3fUwWeBGvVLPMPL3y22eSA== X-Received: by 2002:ac2:5205:: with SMTP id a5mr4414914lfl.138.1619805072056; Fri, 30 Apr 2021 10:51:12 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id q17sm343545lfn.302.2021.04.30.10.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 10:51:10 -0700 (PDT) Date: Fri, 30 Apr 2021 20:51:09 +0300 From: Dmitry Kozlyuk To: Dmitry Malloy Cc: Narcisa Ana Maria Vasile , "dev@dpdk.org" , thomas , Khoa To , Narcisa Ana Maria Vasile , Tyler Retzlaff , "talshn@nvidia.com" , Omar Cardona , "bruce.richardson@intel.com" , "david.marchand@redhat.com" , "Kadam, Pallavi" Message-ID: <20210430205109.1a796833@sovereign> In-Reply-To: <20210430202250.7c91da09@sovereign> References: <1617057640-24301-2-git-send-email-navasile@linux.microsoft.com> <1617413948-10504-1-git-send-email-navasile@linux.microsoft.com> <1617413948-10504-7-git-send-email-navasile@linux.microsoft.com> <20210429234414.73ce39d7@sovereign> <20210430202250.7c91da09@sovereign> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v6 06/10] eal: add thread lifetime management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-30 20:22 (UTC+0300), Dmitry Kozlyuk: > 2021-04-29 21:31 (UTC+0000), Dmitry Malloy: > > [...] > > How about we defer fixing this to another follow-up change? > > I'm strictly against accepting code with known severe bugs. > > Alternative: > > 1. Don't add rte_thread_cancel() in public API. > 2. Implement rte_thread_cancel() as internal API with cancellation tokens. > 3. Rewrite DPDK code to use rte_thread_cancel(). > [...] Or just don't export this function on Windows for now. None of the drivers using it is soon to be enabled for Windows, and portable apps don't need it anyway.