From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C352A0524; Wed, 5 May 2021 09:35:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FABD4115E; Wed, 5 May 2021 09:34:18 +0200 (CEST) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 39F3841147 for ; Wed, 5 May 2021 09:34:15 +0200 (CEST) Received: by mail-wm1-f52.google.com with SMTP id 82-20020a1c01550000b0290142562ff7c9so496071wmb.3 for ; Wed, 05 May 2021 00:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GGtM5qsb7+GqyqX/GA3YsmYDNifrLD8/+HhQUhZLHtY=; b=MvguvR/IYpIgx7PNA77Tk9FS9EPmbiSmgQll0eWxagAVmbK+dE3FPcWf8PwNhJBBcN p5q86gjFaB9VJ2ArJch2eaamYXzNJ1r0T6qe4T+KSLnhO1/DmHdifqq7BA/fm3593tis lzdvrmj8hKXDDgA+4VDFuNASYpjgVXRudYDK6KkfCmhKOjEQiPd6v1qVGnmjCI9bHjyY KqE7kwBVk68ezCvEjlvKJqvhPbkKWbbgUWYVWTHMRzw7OpDqmw/nj7DU8QSnkudfibDJ /ayoII8cV0RMPyB4Pfr50hv1Hs9biy0YEeonN71SZdCIM93+T9uEHa1dX4z84Hi4c7Dd VugQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GGtM5qsb7+GqyqX/GA3YsmYDNifrLD8/+HhQUhZLHtY=; b=gKLp0bZUKxSbyb9fyIXnYbeaNBQAkKGyCwTTN1MT/Iwk3FHhQlebSSOQdFFeg27F9I IfWstQ6QLM/YzAQML7/n2DkSNxFK2Zf3EpctSJ9ZSnjC8FlMkGJsSicO2D1wxjoI3hDB 7xFA7ADiS2aXdlpchqr4Jx+rct4rgl/dnvFI2/xwnOulhJCIH1M7qpNCykocbnLtozRe +uRNqEeCf/DMacIIDwbUlUNwP5mvupaD/Kv/v/4XHLb+ddLc8QuD73V05LrA0dVjedjU ZeJ7GyhsvJMjtp5HGBOSD6MGKQXaV/zkQ2mScWEEVCoedbkYxODBLz5xMpZASDC/nkLp un9w== X-Gm-Message-State: AOAM533ja9/dG9U30XPeWSVyrpbE+gU/o72Fr/ZpVhQNz2tH495wmWWs FLCp+tT/ejoy56KSPT2tV4zcKO0OY+Vk//RK X-Google-Smtp-Source: ABdhPJzQXMXIhtQprRi4ArcCy6br0fP9xZQaTOCVimavwVRenGx2UEdA9uHujkgwnNHd8yL27ywQKw== X-Received: by 2002:a1c:3d44:: with SMTP id k65mr1842235wma.121.1620200054687; Wed, 05 May 2021 00:34:14 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id t17sm4679856wmq.12.2021.05.05.00.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 00:34:14 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, stable@dpdk.org, Shay Agroskin , Michal Krawczyk Date: Wed, 5 May 2021 09:33:38 +0200 Message-Id: <20210505073348.6394-13-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210505073348.6394-1-mk@semihalf.com> References: <20210430125725.28796-1-mk@semihalf.com> <20210505073348.6394-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 12/22] net/ena: fix parsing of large_llq_hdr argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Igor Chauskin The code incorrectly checked the return value of comparison when parsing the argument key name. The return value of strcmp should be compared to 0 to identify a match. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Shay Agroskin Reviewed-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3c9102cd19..cb8ad5c3d0 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2865,7 +2865,7 @@ static int ena_process_bool_devarg(const char *key, } /* Now, assign it to the proper adapter field. */ - if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR)) + if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR) == 0) adapter->use_large_llq_hdr = bool_value; return 0; -- 2.25.1