From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8D46EA0524;
Wed, 5 May 2021 09:35:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C61C341164;
Wed, 5 May 2021 09:34:19 +0200 (CEST)
Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com
[209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 6741F41151
for <dev@dpdk.org>; Wed, 5 May 2021 09:34:16 +0200 (CEST)
Received: by mail-wr1-f41.google.com with SMTP id t18so681860wry.1
for <dev@dpdk.org>; Wed, 05 May 2021 00:34:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=ya29Y1oo4CSGqqdor+vF9iZ5PkFZCJ8mO7cQJ+GXFEQ=;
b=s6lh5DS6DODvI2Wm+hK0RDEkEF2iKMEXTX+xPbg323PYRnzni5plr5g0X9Q0PatTHo
Xwz/xwA+kHmtOn35M1fvFWfBLS3VonmNzl55aLn7sfxdYlobtMxMFrv5BdFSYAB5fcop
N7KFKoc59Ls2Ri1aWOCNTO2jZNy8HKUpy0xyoomJnJdrjVFFNH3hef7j3/I3HxTzdJeQ
5zlseZ4yZFPeEfVp2FO4nAzB0ExHVnf8sbYaSPuhIS/Az7wpcNtIfstWcLeQozY3R5Qx
DuG61txwd3bPNr+0XSxKHd5/uvues+4SRtIpbV0kZq9Mi8zxUvbAqrioy/Ncy6mcJ2zj
5Qkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=ya29Y1oo4CSGqqdor+vF9iZ5PkFZCJ8mO7cQJ+GXFEQ=;
b=tJUdv5N6q8U+QX5te/U9xinTBUp3iHipnFyjPcjCRoeAUYKo2h+OpObT7x5nn2YBhG
0olsyc6NAVMoujpWYLfef5AHwfY9g6ePot/A3DXidSjSVCQ4dihyphVUFmRE2rFqS3Ap
DgYGAfmpcZm4+QTE9/BLyDZh6u65XLDbZhZ0Yn5dr9wtiJsVAaWEwFw192ANTavWLnVj
pcJc3aTE1skZ+K4vTIlpYSawGvYroutQuMLZBQcwPrdHF+SzSuhgEMxHTrpG2XclV7Qw
+5FAb0MIDtR2qjiPobQ7U35wClvFg/OZUhj0ynzkQmInAJ4k56RDgwHbn/LnSfKEcSOv
N1mA==
X-Gm-Message-State: AOAM530WbOinxjKZhvtVBb6BblC+1vN01q7K9WdmFrcZ6/PQ8FseBffu
oI781jnSXTNGvl9Hux57UpNFQbfXTlrtY1hX
X-Google-Smtp-Source: ABdhPJwgPLBPLMKkYNzTHLJsiAxb+kbqOq8MXdzKONUHKqC3Lgzqu4fDua+rbLbnl4AyHfc+/jR59g==
X-Received: by 2002:adf:f043:: with SMTP id t3mr27121743wro.344.1620200055929;
Wed, 05 May 2021 00:34:15 -0700 (PDT)
Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.
[89.79.189.199])
by smtp.gmail.com with ESMTPSA id t17sm4679856wmq.12.2021.05.05.00.34.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 05 May 2021 00:34:15 -0700 (PDT)
From: Michal Krawczyk <mk@semihalf.com>
To: dev@dpdk.org
Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,
upstream@semihalf.com, Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org,
Shay Agroskin <shayagr@amazon.com>
Date: Wed, 5 May 2021 09:33:39 +0200
Message-Id: <20210505073348.6394-14-mk@semihalf.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20210505073348.6394-1-mk@semihalf.com>
References: <20210430125725.28796-1-mk@semihalf.com>
<20210505073348.6394-1-mk@semihalf.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2 13/22] net/ena: terminate devargs allowed keys
with NULL
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
As the documentation of rte_kvargs_parse() states, the valid_keys
argument must be NULL terminated. Lack of this feature may cause
segmentation fault if the passed devarg will be different then the
supported value.
Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers")
Cc: stable@dpdk.org
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
Reviewed-by: Shay Agroskin <shayagr@amazon.com>
---
drivers/net/ena/ena_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index cb8ad5c3d0..6092288239 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter,
{
static const char * const allowed_args[] = {
ENA_DEVARG_LARGE_LLQ_HDR,
+ NULL,
};
struct rte_kvargs *kvlist;
int rc;
--
2.25.1