From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B10C9A0524; Wed, 5 May 2021 09:34:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C53641127; Wed, 5 May 2021 09:34:10 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 75ACD41110 for ; Wed, 5 May 2021 09:34:07 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id 4-20020a05600c26c4b0290146e1feccd8so505556wmv.1 for ; Wed, 05 May 2021 00:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=15FZt3K7cdpAllc/3/WHxIsIzw+Wtoo4ytssIEc5lvA=; b=iRdoSXbhDlFwhdKfQZ0dKDMiIK0D7Lwi9Bofubt0EWcdDRr2KF3QVZTo46qmojRIqX d8Keett5B8cdJP92zFnI1jM40gM5moNsw+aH2159t6ZVGC3pLG5qSRjy9R5mpzxmjHzM qx02Iz8WqiWMATX4NTAUPE3n+coHNU5mLbbVordHmS5lhYAqU6LI8yQSpN9oZf6Wy7nS cBHqYXOvMTtA/kPMwoM2kzxrtc7O6OcwHnps7lVqbHouhsG9b5V6h2C2XzMtCbXyuT/w DzGDtc5p+7gaIfGxHUOPhSUNY1WeepsRVViThvFfbHTJmo/aW9gxBu6tahPHR2QbwV8a aJiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=15FZt3K7cdpAllc/3/WHxIsIzw+Wtoo4ytssIEc5lvA=; b=hajVkWGW2q80x7wgTBC6xU8E8XSsbl/e7fuyMbvqnQ1xLjn/0HANbx73ALxPADSOYt jDFpUlE3p5r5nw3OVuzsr5SL8/lH/gPDC4Hb/xYNbTA/gd5y5FG4eO7/DdJCWDD2tJxi H6NNycqiiVlhAMfecCqaKJagjPFGckjhHKZ6lUon4zLR6BPsHjSKiw7wGKehvGzp05Pw 3sb4PKZ6ajvMV8OGpQt2Ev88NAkuqtnNvMW74qugRLcKRNFb5bsc91f4sNQ5ZDqwyi2d R49uQR8HVCCG4q0M7fSHYXqiQvGY/Hg0zyRr5OgUWpM3K95+Ake9X64gr3SM1VPUjn5n 2lRg== X-Gm-Message-State: AOAM533HLNJWZr8E38bO+Pf1k3GJTpIypofrV+s4/x+AttgPmSVywDIF T/ABkNk7tgk6nn20/XeO3tKaKaYJ8xfPFnG2 X-Google-Smtp-Source: ABdhPJylhBh5UPMCSPjbY1z2e+FmBFZnQdKBzv1OlOcDtBd7ASApx1g93eiXeKZzGofSHyqnjEjWcg== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr31470217wmc.44.1620200046887; Wed, 05 May 2021 00:34:06 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id t17sm4679856wmq.12.2021.05.05.00.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 00:34:06 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, Michal Krawczyk Date: Wed, 5 May 2021 09:33:32 +0200 Message-Id: <20210505073348.6394-7-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210505073348.6394-1-mk@semihalf.com> References: <20210430125725.28796-1-mk@semihalf.com> <20210505073348.6394-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 06/22] net/ena/base: destroy multiple "wait events" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Although the ENA DPDK PMD doesn't have to perform any actions for destroying the wait event, some other platforms have to. The macro "ENA_WAIT_EVENT_DESTROY" was renamed to "ENA_WAIT_EVENTS_DESTROY" and also whole implementation responsible for that was moved to a separate function for better readability. Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 24 +++++++++++++++++------- drivers/net/ena/base/ena_plat_dpdk.h | 4 ++-- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index 0cdeb1a2d9..d025c9cee1 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -1671,6 +1671,22 @@ int ena_com_validate_version(struct ena_com_dev *ena_dev) return 0; } +static void +ena_com_free_ena_admin_queue_comp_ctx(struct ena_com_dev *ena_dev, + struct ena_com_admin_queue *admin_queue) + +{ + if (!admin_queue->comp_ctx) + return; + + ENA_WAIT_EVENTS_DESTROY(admin_queue); + ENA_MEM_FREE(ena_dev->dmadev, + admin_queue->comp_ctx, + (admin_queue->q_depth * sizeof(struct ena_comp_ctx))); + + admin_queue->comp_ctx = NULL; +} + void ena_com_admin_destroy(struct ena_com_dev *ena_dev) { struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue; @@ -1679,14 +1695,8 @@ void ena_com_admin_destroy(struct ena_com_dev *ena_dev) struct ena_com_aenq *aenq = &ena_dev->aenq; u16 size; - if (admin_queue->comp_ctx) { - ENA_WAIT_EVENT_DESTROY(admin_queue->comp_ctx->wait_event); - ENA_MEM_FREE(ena_dev->dmadev, - admin_queue->comp_ctx, - (admin_queue->q_depth * sizeof(struct ena_comp_ctx))); - } + ena_com_free_ena_admin_queue_comp_ctx(ena_dev, admin_queue); - admin_queue->comp_ctx = NULL; size = ADMIN_SQ_SIZE(admin_queue->q_depth); if (sq->entries) ENA_MEM_FREE_COHERENT(ena_dev->dmadev, size, sq->entries, diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h index f1338cd1fe..067909f745 100644 --- a/drivers/net/ena/base/ena_plat_dpdk.h +++ b/drivers/net/ena/base/ena_plat_dpdk.h @@ -166,7 +166,7 @@ extern int ena_logtype_com; #define ENA_WAIT_EVENT_SIGNAL(waitevent) pthread_cond_signal(&waitevent.cond) /* pthread condition doesn't need to be rearmed after usage */ #define ENA_WAIT_EVENT_CLEAR(...) -#define ENA_WAIT_EVENT_DESTROY(waitqueue) ((void)(waitqueue)) +#define ENA_WAIT_EVENT_DESTROY(admin_queue) ((void)(admin_queue)) #define ena_wait_event_t ena_wait_queue_t #define ENA_MIGHT_SLEEP() @@ -298,7 +298,7 @@ extern rte_atomic32_t ena_alloc_cnt; #define ENA_TIME_EXPIRE(timeout) (timeout < rte_get_timer_cycles()) #define ENA_GET_SYSTEM_TIMEOUT(timeout_us) \ (timeout_us * rte_get_timer_hz() / 1000000 + rte_get_timer_cycles()) -#define ENA_WAIT_EVENT_DESTROY(waitqueue) ((void)(waitqueue)) +#define ENA_WAIT_EVENTS_DESTROY(waitqueue) ((void)(waitqueue)) #ifndef READ_ONCE #define READ_ONCE(var) (*((volatile typeof(var) *)(&(var)))) -- 2.25.1