From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 096F5A0A0C; Thu, 6 May 2021 04:54:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0442410F2; Thu, 6 May 2021 04:54:15 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 1EC3D410DB for ; Thu, 6 May 2021 04:54:15 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id m11so4007177pfc.11 for ; Wed, 05 May 2021 19:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d0OESt9ToP5TqqoXGuaripr6C1oqEwvxgr2LPlCLE3w=; b=ognYU5Vh6ch0YqWBe3+46++NOMy5IFH3WKI/DHrfqRkILKH7689GlVdUXLGcrYmWXE ktwixefDVvdb0LXn5jcN/N8wZ40tZdmYd0gLnGVKwkkdwM14dZiycxp93REApQQSO85T nAMX0JvPYYaDBj20hxM8lPMV3HZPx4MWu0FIcD8QM7k/aeTTXkDyvC6f7obQVBApfFv4 hGS9A781nYAZJ9r61U2WtPCgMVyuOJvPvBBZw6G19zJ4EAikzq4Mr7f47/K04/07HNUh ktxRqkAcUzG4GEr0Wslz9JISfxg+bDsdqcWd/RrSu2IDYL8a7c73aU+34GddAOyPZvcT DsKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d0OESt9ToP5TqqoXGuaripr6C1oqEwvxgr2LPlCLE3w=; b=QzPSc/Vfiocmt5m3V2Yjt8RpVHkPLlXGdgwHruXWWWWc77V7OJhcSR1MtV1Co0TfJJ 4s/CFbYW8984VIi7PjDG0XR7T9wgvoFtMhlZGu9QojmlP+if4eEdUDFAm8+GBPvHdbLT 4IDx5gnhjftOSqLsJrNtkVpOB/g3x0SFcTzhqWD+wKPa3y10OQ0WJMCyE01u7ZDuhU+A XIRPydC9NSC6Oiv5i9NxkSYvQ2iPO19JuZUHtfHeYdIJnglO65U1wYGHAuaLRn6rtSRi yHTgIXvQ4St+pjyMszkH1+pOiLx5ePq2a4lOlUy6yK2bGGWo8ZKdOi+gvUm2cq3Fr5H+ gJIQ== X-Gm-Message-State: AOAM533v3Um0T2HZS33F2DWkFYYdUvV/cBhagtNwAgd8HE+3g2Jo7mrX DmQbccy2s22jQT5YZa4xkfM5fw== X-Google-Smtp-Source: ABdhPJwThblSVp3iLso1ZWEjG3WvktS1HlyIj5ze2J9s3q6r88oq3WblrPoM78hO1H9fpkXOrl6YkA== X-Received: by 2002:aa7:985c:0:b029:28f:8ca0:f7c with SMTP id n28-20020aa7985c0000b029028f8ca00f7cmr2048413pfq.37.1620269654172; Wed, 05 May 2021 19:54:14 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id b13sm579636pjl.38.2021.05.05.19.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 19:54:13 -0700 (PDT) Date: Wed, 5 May 2021 19:54:05 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org, stable@dpdk.org, Tyler Retzlaff , Bruce Richardson , John McNamara Message-ID: <20210505195405.2d0a57d6@hermes.local> In-Reply-To: <20210505215133.21818-1-dmitry.kozliuk@gmail.com> References: <20210502025656.29910-1-dmitry.kozliuk@gmail.com> <20210505215133.21818-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] examples/rxtx_callbacks: fix port ID format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 6 May 2021 00:51:33 +0300 Dmitry Kozlyuk wrote: > This fixes -Wformat warning with clang 10.0.0 on Windows. > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > Acked-by: Tyler Retzlaff > --- > v2: use PRIx16 instead of %u and a cast (Tyler, Thomas). > > examples/rxtx_callbacks/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbacks/main.c > index b57b2fc6bc..ecc2da2d8c 100644 > --- a/examples/rxtx_callbacks/main.c > +++ b/examples/rxtx_callbacks/main.c > @@ -329,7 +329,7 @@ main(int argc, char *argv[]) > /* initialize all ports */ > RTE_ETH_FOREACH_DEV(portid) > if (port_init(portid, mbuf_pool) != 0) > - rte_exit(EXIT_FAILURE, "Cannot init port %"PRIu8"\n", > + rte_exit(EXIT_FAILURE, "Cannot init port %"PRIx16"\n", > portid); > > if (rte_lcore_count() > 1) NAK Just use %u it works for uint16. Don't start using hex, no other places in DPDK print port number in hex.