From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3E92A0524; Thu, 6 May 2021 00:45:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FF5640040; Thu, 6 May 2021 00:45:23 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D9CF74003C; Thu, 6 May 2021 00:45:21 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 1E6D520B7178; Wed, 5 May 2021 15:45:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1E6D520B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1620254721; bh=DpqkKq+hwYEX2RTi2/e21W3cg989I6oDgyXaBl3nPYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EfFhaS3MwVYTJ1cBvHFdUibHldMCb0eE/d0sgkc1+7Dc1A9TnQDexI5apiMr+sLKP jVeR0Cyxe0IS/NHq/QAz15J69nkytaMW6U5os1Vvw8Nl0H7WSm/faccv9JLgM9A2Ov tC08O6371SSLw9nJ3E80Oj5vVIpqtGpKkGt2PaUQ= Date: Wed, 5 May 2021 15:45:21 -0700 From: Tyler Retzlaff To: Thomas Monjalon Cc: Dmitry Kozlyuk , stable@dpdk.org, dev@dpdk.org, Bruce Richardson , John McNamara Message-ID: <20210505224521.GA32065@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210502025656.29910-1-dmitry.kozliuk@gmail.com> <20210504094822.7072ef01@sovereign> <20210505160042.GB13051@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <10660804.QYKOPib57F@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10660804.QYKOPib57F@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix port ID format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 05, 2021 at 11:39:23PM +0200, Thomas Monjalon wrote: > 05/05/2021 18:00, Tyler Retzlaff: > > On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote: > > > > > > > > what was the -Wformat clang on windows complaint? > > > > > > PRIx16 would work, but I noticed that in other places where port ID is > > > printed, the pattern above is used. IMO uniform approach is better. > > > > ah, consistency. yes i'll have some of that. maybe one day in the future > > we can change them all in one shot, but not today. > > > > Acked-By: Tyler Retzlaff > > I think PRIu16 is more appropriate. works for me. > Consistency doesn't matter if an approach is better. well, there is some value in having consistency even if it is something sub-optimal if we intend to do a mechanical change of all instances in the future. as a side question, what is the projects stance on getting more warnings clean? there are a few not enabled that i'd really like to see e.g. format, conversion, truncation etc.. i looked at lib/eal previously and there are... hundreds? of instances so it's a non-trivial task. the problem i see is somehow getting to a warnings clean state where we can enable -Werror in the CI pipeline but at the same time figuring out how to prevent new instances from appearing until we do.