From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2519A0C43; Fri, 7 May 2021 22:51:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2649F4013F; Fri, 7 May 2021 22:51:50 +0200 (CEST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id 52AFD40040; Fri, 7 May 2021 22:51:48 +0200 (CEST) Received: by mail-lf1-f42.google.com with SMTP id x20so14560464lfu.6; Fri, 07 May 2021 13:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U+xVykyrOYFZ22L/sWy6JN32HHe69C6sqGGOLCvt25E=; b=pZ7kr8BW97Sk5hKL1vpLcVxrsl4lOD4wiwcjI4RIsGUjKmhpSpfgu0jI4P+iHUcmvA AUoXuyS3P4pjOValfDKQ6VvFYs5pJZMoFwZ0bL+ExO6IDzVt+KsKkP9/fmXmwToPblWv cojnGBa4u8YMYYs5v0waCnVKPDAJhWTWwNQlWER2bh+yMsCXPx9iYxnTF5jR7sA7j/ge yczMWoF2bsEdSBNyc3pxGzehfm7wpPel8OMAZJ23jSpBTgitckSNJliG9TfMEauJu7vG wWAbEicyA46owhw4wjlgGvtW7dglFQ0Kau6k75pdHuW6sXfy3IYfsa8NGWgeEmjysWV+ DvKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U+xVykyrOYFZ22L/sWy6JN32HHe69C6sqGGOLCvt25E=; b=Xne3V2KDH9NPt7FKGRUgcIQ2vyFBs6P5hTT14cLJhvPm8Tty7TUajE+Z86My0cSRIy HAq4hBKolsnVljM6qFTk3ovL8rk29irTsWZyG9HUN3S95KXPY0aEXtJ1cfBeqdNPdQPS H2lN19DKjISnVX1q6b0gms+DOAUm4TKA8oR7F+6RF7w5go/8hdvcP2EzizHdZ7O4M60A wX/e3hp6DHYhhnWojxWwPITWv/+g0JGZmJLucNKrjeWBNDpfDZQ5TTTTbcDTFo6F4lG/ FBpO5FMIwXbd96dz8bKguR7Gox8BrNqG5R69S8ovKGKO+NoMaot90j6DnYVIFLReJt5i hoeQ== X-Gm-Message-State: AOAM532EtpHB1AAZHEthw/7UB6xudEHm/ALUOqrdv3ottBsPrvqri2BV HJKzC+tpcBuTcoGpDdrPFEE= X-Google-Smtp-Source: ABdhPJyeEl4H8y6mi66BMy3t58gNnAXBS3HcsR92u85ds3T7SgURLUwuXr7B7Pgl1gzUvqOdtKc25g== X-Received: by 2002:ac2:44b2:: with SMTP id c18mr7900459lfm.503.1620420707912; Fri, 07 May 2021 13:51:47 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v21sm2031961ljv.80.2021.05.07.13.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 13:51:47 -0700 (PDT) Date: Fri, 7 May 2021 23:51:46 +0300 From: Dmitry Kozlyuk To: Lance Richardson Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, stable@dpdk.org Message-ID: <20210507235146.133c3706@sovereign> In-Reply-To: <20210507190657.84927-1-lance.richardson@broadcom.com> References: <20210507181025.84012-1-lance.richardson@broadcom.com> <20210507190657.84927-1-lance.richardson@broadcom.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: fix memory mapping for 32-bit targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-05-07 15:06 (UTC-0400), Lance Richardson: [...] > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c > index ec7156df96..41a94a7511 100644 > --- a/lib/eal/unix/eal_unix_memory.c > +++ b/lib/eal/unix/eal_unix_memory.c > @@ -24,14 +24,14 @@ > > static void * > mem_map(void *requested_addr, size_t size, int prot, int flags, > - int fd, size_t offset) > + int fd, uint64_t offset) > { > void *virt = mmap(requested_addr, size, prot, flags, fd, offset); > if (virt == MAP_FAILED) { > RTE_LOG(DEBUG, EAL, > - "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%zx): %s\n", > - requested_addr, size, prot, flags, fd, offset, > - strerror(errno)); > + "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%llx): %s\n", > + requested_addr, size, prot, flags, fd, > + (unsigned long long)offset, strerror(errno)); Why not PRIx64?