DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode
@ 2021-04-25  9:26 Alvin Zhang
  2021-04-27  2:31 ` Rong, Leyi
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Alvin Zhang @ 2021-04-25  9:26 UTC (permalink / raw)
  To: qi.z.zhang, qiming.yang; +Cc: dev, Alvin Zhang, stable

In some cases, it seems that the txq mbuf vector release mode
is enabled first, and then it is confirmed that the conditions
for using the vector mode are not met.

This patch puts the txq vector mode startup process after the
condition detection.

Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 92fbbc1..49abcb2 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3303,13 +3303,6 @@
 		if (tx_check_ret >= 0 &&
 		    rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
 			ad->tx_vec_allowed = true;
-			for (i = 0; i < dev->data->nb_tx_queues; i++) {
-				txq = dev->data->tx_queues[i];
-				if (txq && ice_txq_vec_setup(txq)) {
-					ad->tx_vec_allowed = false;
-					break;
-				}
-			}
 
 			if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512 &&
 			rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
@@ -3329,6 +3322,15 @@
 			if (!use_avx512 && tx_check_ret == ICE_VECTOR_OFFLOAD_PATH)
 				ad->tx_vec_allowed = false;
 
+			if (ad->tx_vec_allowed) {
+				for (i = 0; i < dev->data->nb_tx_queues; i++) {
+					txq = dev->data->tx_queues[i];
+					if (txq && ice_txq_vec_setup(txq)) {
+						ad->tx_vec_allowed = false;
+						break;
+					}
+				}
+			}
 		} else {
 			ad->tx_vec_allowed = false;
 		}
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-05-08  5:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25  9:26 [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode Alvin Zhang
2021-04-27  2:31 ` Rong, Leyi
2021-04-27  3:00   ` Zhang, Qi Z
2021-04-28 10:03 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-05-06  2:37   ` Zhang, AlvinX
2021-05-08  1:20 ` [dpdk-dev] [PATCH v2] net/ice: fix txq vector path selection Alvin Zhang
2021-05-08  2:37   ` Zhang, Qi Z
2021-05-08  3:10     ` Zhang, AlvinX
2021-05-08  3:11   ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2021-05-08  5:53     ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).