DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alvin Zhang <alvinx.zhang@intel.com>
To: beilei.xing@intel.com, Ting.Xu@intel.com
Cc: dev@dpdk.org, Alvin Zhang <alvinx.zhang@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3 3/3] net/iavf: fix V-channel message status
Date: Tue, 11 May 2021 10:02:46 +0800	[thread overview]
Message-ID: <20210511020246.11108-3-alvinx.zhang@intel.com> (raw)
In-Reply-To: <20210511020246.11108-1-alvinx.zhang@intel.com>

Add support of VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED for facilitating
compatibility with PF.

Change the error log-level from ERROR to WARNING when a V-channel
message is not supported by PF, because the VF may still be able to
run without certain features which not supported by PF.

Fixes: 0c35eecfe8b5 ("net/iavf: fix VF to PF command failure handling")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/iavf/iavf_vchnl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 5d57e8b..ca5c56e 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -234,8 +234,10 @@
 			_clear_cmd(vf);
 			err = -EIO;
 		} else if (vf->cmd_retval ==
-			   VIRTCHNL_STATUS_ERR_NOT_SUPPORTED) {
-			PMD_DRV_LOG(ERR, "Cmd %d not supported", args->ops);
+			   VIRTCHNL_STATUS_ERR_NOT_SUPPORTED ||
+			   vf->cmd_retval ==
+			   VIRTCHNL_STATUS_ERR_NOT_IMPLEMENTED) {
+			PMD_DRV_LOG(WARNING, "Cmd %d not supported", args->ops);
 			err = -ENOTSUP;
 		} else if (vf->cmd_retval != VIRTCHNL_STATUS_SUCCESS) {
 			PMD_DRV_LOG(ERR, "Return failure %d for cmd %d",
-- 
1.8.3.1


      parent reply	other threads:[~2021-05-11  2:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  1:50 [dpdk-dev] [PATCH v2 1/3] net/i40e: fix return status for unsupported VF message Alvin Zhang
2021-05-11  1:50 ` [dpdk-dev] [PATCH v2 2/3] common/iavf: fix V-channel status Alvin Zhang
2021-05-11  1:50 ` [dpdk-dev] [PATCH v2 3/3] net/iavf: fix V-channel message status Alvin Zhang
2021-05-11  2:02 ` [dpdk-dev] [PATCH v3 1/3] net/i40e: fix return status for unsupported VF message Alvin Zhang
2021-05-11  2:02   ` [dpdk-dev] [PATCH v3 2/3] common/iavf: fix V-channel status Alvin Zhang
2021-05-11  2:40     ` Xing, Beilei
2021-05-11  2:02   ` Alvin Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511020246.11108-3-alvinx.zhang@intel.com \
    --to=alvinx.zhang@intel.com \
    --cc=Ting.Xu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).