From: Alvin Zhang <alvinx.zhang@intel.com>
To: beilei.xing@intel.com, Ting.Xu@intel.com
Cc: dev@dpdk.org, Alvin Zhang <alvinx.zhang@intel.com>
Subject: [dpdk-dev] [PATCH v2] net/iavf: fix error logs
Date: Tue, 11 May 2021 10:11:16 +0800 [thread overview]
Message-ID: <20210511021116.30844-1-alvinx.zhang@intel.com> (raw)
In-Reply-To: <20210510122050.32668-2-alvinx.zhang@intel.com>
Remove some useless logs which are duplicated of the lower-level
function logs and may confuse users when running VF without some
features that not supported by PF.
Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF")
Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index ca5c56e..dfa7ce3 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1519,11 +1519,8 @@
args.out_size = IAVF_AQ_BUF_SZ;
err = iavf_execute_vf_cmd(adapter, &args);
- if (err) {
- PMD_DRV_LOG(ERR,
- "Failed to execute command of OP_GET_RSS_HENA_CAPS");
+ if (err)
return err;
- }
*caps = ((struct virtchnl_rss_hena *)args.out_buffer)->hena;
return 0;
@@ -1535,7 +1532,6 @@
struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);
struct virtchnl_rss_hena vrh;
struct iavf_cmd_info args;
- int err;
vrh.hena = hena;
args.ops = VIRTCHNL_OP_SET_RSS_HENA;
@@ -1544,12 +1540,7 @@
args.out_buffer = vf->aq_resp;
args.out_size = IAVF_AQ_BUF_SZ;
- err = iavf_execute_vf_cmd(adapter, &args);
- if (err)
- PMD_DRV_LOG(ERR,
- "Failed to execute command of OP_SET_RSS_HENA");
-
- return err;
+ return iavf_execute_vf_cmd(adapter, &args);
}
int
--
1.8.3.1
next prev parent reply other threads:[~2021-05-11 2:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 12:20 [dpdk-dev] [PATCH 1/3] net/i40e: fix return status for unsupported VF message Alvin Zhang
2021-05-10 12:20 ` [dpdk-dev] [PATCH] net/iavf: fix error logs Alvin Zhang
2021-05-11 2:11 ` Alvin Zhang [this message]
2021-05-11 8:35 ` Zhang, Qi Z
2021-05-12 5:48 ` [dpdk-dev] [PATCH] net/i40e: fix VF RSS configuration Alvin Zhang
2021-05-12 6:16 ` Xing, Beilei
2021-05-12 6:26 ` [dpdk-dev] [PATCH v2] " Alvin Zhang
2021-05-12 7:16 ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2021-05-12 9:23 ` [dpdk-dev] [PATCH v4] " Alvin Zhang
2021-05-12 9:26 ` Xing, Beilei
2021-05-12 10:34 ` Zhang, Qi Z
2021-05-10 12:20 ` [dpdk-dev] [PATCH 2/3] common/iavf: fix V-channel status Alvin Zhang
2021-05-10 12:20 ` [dpdk-dev] [PATCH 3/3] net/iavf: " Alvin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511021116.30844-1-alvinx.zhang@intel.com \
--to=alvinx.zhang@intel.com \
--cc=Ting.Xu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).