From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1B65A0C41; Tue, 11 May 2021 08:47:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9872141154; Tue, 11 May 2021 08:46:31 +0200 (CEST) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mails.dpdk.org (Postfix) with ESMTP id A25244111A for ; Tue, 11 May 2021 08:46:26 +0200 (CEST) Received: by mail-lj1-f179.google.com with SMTP id v5so23765043ljg.12 for ; Mon, 10 May 2021 23:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GFu40ZeuROtUu7jdRkSs0exzTNy48rcdOkZ6UIWwY6k=; b=ICxCWOVJ8t9O9/Xw/e0MXtYEs50Id36E1ZvHqxcY8gzkvOdmiAeGo665OALaOJHukb o2NEDpJzxRdWIzABXUnBWhlDXkJsf3gn525wolv7l7fJ5kLeK+8sYbV7lE1PlRMTa5+R lLNrTKYHaIpTrLFF3+zl/N5r8OVhSnZofoYnGQ4Avmb3BA1Gkoh8XIeDNfwYYmBtU1Dy VMU2mlX6im/uKfmyKhhm4L8jPQBJ3QkQgxmvGf1wT4Frpy7JGsfeu8NNaQhF7nxV0DoL wPpFiDT+LirtRH2ckjRP/kfVlhufdGturzjop1gk6N51N3TzkdmAmwQKkQbuW87HXhY2 a5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GFu40ZeuROtUu7jdRkSs0exzTNy48rcdOkZ6UIWwY6k=; b=qRd/O+COsMeO3ODfFrzcrYSi04+ZI6JGdCakvbGxqQ0SBTVH191PI8Xd3L4kbzz4tl 3NJOYxsfUUYi9nqwZff3XgXo0Ww6iAcET6hG/+ujiA1XskD1jD23YmOc9Z4vPASvPTqk UPwKwHgvT0NkZpZHUHIfXrLdfRrebq+5Skc1FE9hm0RVI5yMhe0Tr4psEaMgsbGFVtvF Sg/gwn+IdkVdJMguiuD7ImNwTRT867FvqcIaZK/IUg5+YMPiHsIbA30avv70T2LGoGM3 +TJLwo3pQfRBzj+jPwORs5y4vzSZrAEsEj70fsSo3NtCrmPNMpK/6Cu+b+H72Ko75QrY LDkQ== X-Gm-Message-State: AOAM533C2VkdzHBlreEGi7HMOPeRtBYzscwe0nkUn6+SzpgxlJPQofSV U5dqimnhWUZXLek8zC2atui05A== X-Google-Smtp-Source: ABdhPJzqCToNOIEz/BxM3OcE4ijEhSsh1NlKB4/U3oOwSMwYG7u6fLONc96EqtYy5WTyYTea4jU1wg== X-Received: by 2002:a2e:8797:: with SMTP id n23mr3491641lji.248.1620715586317; Mon, 10 May 2021 23:46:26 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id v20sm2496776lfd.92.2021.05.10.23.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 23:46:25 -0700 (PDT) From: Michal Krawczyk To: ferruh.yigit@intel.com Cc: dev@dpdk.org, ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, stable@dpdk.org, Shay Agroskin , Michal Krawczyk Date: Tue, 11 May 2021 08:45:46 +0200 Message-Id: <20210511064554.10656-12-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210511064554.10656-1-mk@semihalf.com> References: <87e65a42-4ae5-1a81-8f8e-74759fc14999@intel.com> <20210511064554.10656-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 11/19] net/ena: fix parsing of large LLQ header devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Igor Chauskin The code incorrectly checked the return value of comparison when parsing the argument key name. The return value of strcmp should be compared to 0 to identify a match. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Shay Agroskin Reviewed-by: Michal Krawczyk --- v4: * Add release notes. * Fix commit heading style. doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/ena/ena_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 6e4fcde1bc..755d5fcd32 100644 --- a/doc/guides/rel_notes/release_21_05.rst +++ b/doc/guides/rel_notes/release_21_05.rst @@ -209,6 +209,7 @@ New Features * Changed memcpy mapping to the dpdk-optimized version. * Updated ena_com (HAL) to the latest version. + * Fixed bugs when requesting large LLQ headers using the devargs. * **Added support of multiple data-units in cryptodev API.** diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3c9102cd19..cb8ad5c3d0 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2865,7 +2865,7 @@ static int ena_process_bool_devarg(const char *key, } /* Now, assign it to the proper adapter field. */ - if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR)) + if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR) == 0) adapter->use_large_llq_hdr = bool_value; return 0; -- 2.25.1