From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 472CAA0C41; Tue, 11 May 2021 08:47:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E54824115A; Tue, 11 May 2021 08:46:32 +0200 (CEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id EBC3641142 for ; Tue, 11 May 2021 08:46:27 +0200 (CEST) Received: by mail-lf1-f41.google.com with SMTP id x2so27019036lff.10 for ; Mon, 10 May 2021 23:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8qPrxRFwFGeW1O5g5Fpv0S1w/mScFeGzPp0onxAutk4=; b=j4NZG5jMXm/877oZkswOeiQpG37acvotTzv5NMiOmF3DPlIaGCmL9WFTEcD8+l3Ivb iXCoaLdfUtCFlZ4h33rB1zbFDvydxirCx7o8zLXI7CCU6QpFUgifGzfssIBJmTgoqWYi 0elIfbkjilfVjNiyKmovUoKyDCDtCjcAAq5JyMHTQaF9swsvHwC3DWnhepNbgbd9q3Ci Vc1Vl4VqX2S4q4GAJoW200Wj7wTJyqw981vj6hE4vM3SGJCjj/qI/XFI8i/dHuZoseNg bvi/8iLUv+3p6GGqjmjMUU2Kpa1xVbFKePe0sjyvd4BGiHkEtQDf/sXpSagdkR9ItM/R U9Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8qPrxRFwFGeW1O5g5Fpv0S1w/mScFeGzPp0onxAutk4=; b=Nl1GAKe7jVG/rOXyOmYO5y1NyBAQBww1VakPlmZaOXUjCE/Z6SLV4H83F9gRkSmC5K Jpi3kHxudldZs312AuCx1hmBsSAD14n6I1ZxB/F/EAKNR+b/wIfOJOqdwrPppoTKsxX+ DIigtIKW5tuECbv94endH6xdqlFEU8wkJv4locBUCk3s7le3tiOgXy0xPDjG0Cc0Vvjk 1ohdHHfqGVzQHaEPeYp7AAFt06YDvbu6VC1WXKK5vJ3HORoIqhyiayXGJv6y4c36+dV2 RGhEhZ8CoaUIpuDiX83RGBBifD2RXevA6kKHHEW/eACLp9TN06b20CguCqp0YEBjn8NW wZNA== X-Gm-Message-State: AOAM533subGysixXH1QvdKbiDDZ55+q2gzEFz5sGoZTfv9rPKKrZXZEb H6KnrqQMY4gncq2VOHqgyNVL8w== X-Google-Smtp-Source: ABdhPJwwIT0kfhsOUVs9i0haUu+0nGdp3upwFt20V9irP/xh++jh8suHnmp0wHB2gDmgZMW45steSA== X-Received: by 2002:a05:6512:3455:: with SMTP id j21mr11455222lfr.235.1620715587621; Mon, 10 May 2021 23:46:27 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id v20sm2496776lfd.92.2021.05.10.23.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 23:46:26 -0700 (PDT) From: Michal Krawczyk To: ferruh.yigit@intel.com Cc: dev@dpdk.org, ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, Michal Krawczyk , stable@dpdk.org, Shay Agroskin Date: Tue, 11 May 2021 08:45:47 +0200 Message-Id: <20210511064554.10656-13-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210511064554.10656-1-mk@semihalf.com> References: <87e65a42-4ae5-1a81-8f8e-74759fc14999@intel.com> <20210511064554.10656-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 12/19] net/ena: terminate devargs allowed keys with null X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As the documentation of rte_kvargs_parse() states, the valid_keys argument must be NULL terminated. Lack of this feature may cause segmentation fault if the passed devarg will be different then the supported value. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroskin Acked-by: Ferruh Yigit --- v4: * Fix commit heading style. drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index cb8ad5c3d0..6092288239 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter, { static const char * const allowed_args[] = { ENA_DEVARG_LARGE_LLQ_HDR, + NULL, }; struct rte_kvargs *kvlist; int rc; -- 2.25.1