From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A5E8A0A0E; Tue, 11 May 2021 13:34:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB14840140; Tue, 11 May 2021 13:34:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id F2A014003E for ; Tue, 11 May 2021 13:34:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620732858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OV94gUgd/hsMv1EXOybQMymjCj81znTZ0lOiPb8NuJA=; b=NfJMzePM6lxsA/5w1VuL1gtf1ZLfbd7vPsVd4R/vZyZBDPcJzK3xO+mIpDH9O+g8EoiIyw EWLQ/15/dOWwiE2TVYNJ9ajfsn14/wWOxU6TI7pf9r8D+Q83hEUDhGjN/4E+JgPHLmL7+d /0SzE51cEnAY2OGDt+5wDhR6P9zOSDg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-sC6yYHu-M4eKkXYzssD3mA-1; Tue, 11 May 2021 07:34:16 -0400 X-MC-Unique: sC6yYHu-M4eKkXYzssD3mA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E60D801B1A; Tue, 11 May 2021 11:34:15 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 272D96787A; Tue, 11 May 2021 11:34:09 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: timothy.mcdaniel@intel.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com Date: Tue, 11 May 2021 13:33:56 +0200 Message-Id: <20210511113358.2485-1-david.marchand@redhat.com> In-Reply-To: <20210506094452.1689-1-david.marchand@redhat.com> References: <20210506094452.1689-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2 0/2] Thread termination leak fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" After looking at the control thread API use in recent changes, I noticed that some thread resources are not properly released. This series fixes two net drivers. Additional notes: - I noticed that event/dlb2 never kills/terminates its service thread. It means unplug of this device (if supported) would leak the associated thread resources. I leave it to this driver maintainer to comment/fix. - The vhost library also lets a service thread in the background but since there is no way to unitialize this library, there is no leak to fix from my pov. -- David Marchand Changes since v1: - fixed build for net/ice on Windows David Marchand (2): net/ark: fix leak on thread termination net/ice: fix leak on thread termination drivers/net/ark/ark_pktgen.c | 2 ++ drivers/net/ice/ice_dcf_parent.c | 2 ++ lib/eal/windows/include/pthread.h | 6 ++++++ 3 files changed, 10 insertions(+) -- 2.23.0