From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B622A0A0E; Tue, 11 May 2021 13:45:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 274F841108; Tue, 11 May 2021 13:45:09 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 13A944110E; Tue, 11 May 2021 13:45:06 +0200 (CEST) IronPort-SDR: AoJ7qkTHITsjfSwsJiHSPizTO7s82FJ1+Cuwm6Ge8a2warY7lk88UdNULfgiNePeFoCVSDUI6L 8YuPY6kz3BVQ== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="199100207" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="199100207" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 04:45:06 -0700 IronPort-SDR: dAxLreOMLuJOR+BnABbd0Fiwhe6NqN6E8HDnONvVJmuoqjOyBqxLiA5F0BAXJx+zJfpvbGzjyt +W0UU7zT0MYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="609457442" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.27]) by orsmga005.jf.intel.com with ESMTP; 11 May 2021 04:45:03 -0700 From: Ferruh Yigit To: Qiming Yang , Qi Zhang , Paul M Stillwell Jr , Wenzhuo Lu , Shivanshu Shukla , Leyi Rong Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, Kevin Traynor , Ajit Khaparde Date: Tue, 11 May 2021 12:44:53 +0100 Message-Id: <20210511114454.3923410-3-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511114454.3923410-1-ferruh.yigit@intel.com> References: <20210510150319.1496105-1-ferruh.yigit@intel.com> <20210511114454.3923410-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 3/4] net/ice/base: fix build with gcc11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) There are multiple build errors, like: ../drivers/net/ice/base/ice_switch.c: In function ‘ice_add_marker_act’: ../drivers/net/ice/base/ice_switch.c:3727:15: warning: array subscript ‘struct ice_aqc_sw_rules_elem[0]’ is partly outside array bounds of ‘unsigned char[52]’ [-Warray-bounds] 3727 | lg_act->type = CPU_TO_LE16(ICE_AQC_SW_RULES_T_LG_ACT); | ^~ In file included from ../drivers/net/ice/base/ice_type.h:52, from ../drivers/net/ice/base/ice_common.h:8, from ../drivers/net/ice/base/ice_switch.h:8, from ../drivers/net/ice/base/ice_switch.c:5: ../drivers/net/ice/base/ice_osdep.h:209:29: note: referencing an object of size 52 allocated by ‘rte_zmalloc’ 209 | #define ice_malloc(h, s) rte_zmalloc(NULL, s, 0) | ^~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ice/base/ice_switch.c:3720:50: note: in expansion of macro ‘ice_malloc’ lg_act = (struct ice_aqc_sw_rules_elem *)ice_malloc(hw, rules_size); These errors are mainly because allocated memory is cast to "struct ice_aqc_sw_rules_elem *" but allocated size is less than the size of "struct ice_aqc_sw_rules_elem". "struct ice_aqc_sw_rules_elem" has multiple other structs has unions, based on which one is used allocated memory being less than the size of "struct ice_aqc_sw_rules_elem" is logically correct but compiler is complaining about it. Since the allocation is done explicitly and both producer and consumer are internal, safe to ignore the warnings. Also to prevent any side affect disabling the compiler warning for now, until proper fix done. Reducing the warning disable to gcc >= 11 version. Bugzilla ID: 678 Fixes: c7dd15931183 ("net/ice/base: add virtual switch code") Fixes: 02acdce2f553 ("net/ice/base: add MAC filter with marker and counter") Fixes: f89aa3affa9e ("net/ice/base: support removing advanced rule") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: paul.m.stillwell.jr@intel.com Cc: qi.z.zhang@intel.com Cc: leyi.rong@intel.com Cc: Kevin Traynor Cc: Ajit Khaparde v2: * Kevin reported more occurrences, the concern is to have more as the gcc version updated. And as the size of changes increases, the risk of unexpected side affect also increases. So disabling the 'array-bounds' warning for this release for gcc >= 11.0.0. --- drivers/net/ice/base/meson.build | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build index 6c548a99775c..3305e5dd1822 100644 --- a/drivers/net/ice/base/meson.build +++ b/drivers/net/ice/base/meson.build @@ -23,6 +23,11 @@ error_cflags = [ '-Wno-unused-parameter', ] +# Bugzilla ID: 678 +if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0')) + error_cflags += ['-Wno-array-bounds'] +endif + if is_windows and cc.get_id() != 'clang' cflags += ['-fno-asynchronous-unwind-tables'] endif -- 2.31.1