From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 439A2A0A0E; Tue, 11 May 2021 15:09:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BDEE40697; Tue, 11 May 2021 15:09:49 +0200 (CEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 15D964003E for ; Tue, 11 May 2021 15:09:47 +0200 (CEST) Received: by mail-wr1-f46.google.com with SMTP id h4so20057820wrt.12 for ; Tue, 11 May 2021 06:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=13jCpBpAYmmp0GxX7ZYCijjCDrcoC6OZ/z0XW+Mx8c8=; b=ZBeBiyZ0rJGTTDUbZJLfqe50RY8uMitODiauJTbgds6ZJL7l0z2QhZufFZg+CpseEi fafZiokPNNOfitYXEZA2FGrAMUbcBUx0QqgZkrimvzo574gY/5094gelorcLbVnRtM4S gtWQSomGoX9ZZOMNPSRJbWua8pP4VIImjYSnAlRgULYZ2xB/HYk/WH+I4HQ5BoZIqImw VG2eelaZg9qle8gIruq//iWvS1qbWMDkL+K1TUGBV4RgZdLb9ugRUyt3AnlYRSZgxbLr O7NF+OekWIRIuu0SQ/3y3XPSSGIJB+VF6eaj0LIkWbhlJXcwnmsjpLlsEHgYwpwZTXqL WwRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=13jCpBpAYmmp0GxX7ZYCijjCDrcoC6OZ/z0XW+Mx8c8=; b=F/8JOYVHTY5AZqVTpxQYdMdqhxzBfBUrvR1D7EuAGcsJFuqEh0/Dl7oXMShJRA4gZ/ MDRppqOvuA7EF4MZQBIxD2V2PHnY2nhsOveYP68sRxilsYjIFilqIiUvbtdrt5M9G1cA uB8m/B8irfpwKZWVuNqf5HIXQxrm26syoOIpnbfLTjJyhRZJ19oW6o1pckjZaF2iy6kI yA91c9wV0+tytMgzui6PkOtsDjeuPxsjALioK7q35tozIZveo1GmdvJpP/WQMMLvKLrV LJVbMhB6W2LebOlWT0MBIzNdGp0gihwiimZtyc3Rwcjfe+0AtLiV+Hcu+/unWOzVnCsJ fewQ== X-Gm-Message-State: AOAM5323H2jsZ2m2VOyNScuimyj5Wdl4On2WCNTe8qduFSuIheYWuunM iRVf8af2qfDxqs0OQ4WjS+x9nw== X-Google-Smtp-Source: ABdhPJwCNES+LOPKsw4aSdZ1aXGSJVar0gKQXbUIBNQwsSjrCAAJ3xPEJIGRg4gDNQNLmA2s5TSBUg== X-Received: by 2002:adf:e84a:: with SMTP id d10mr37990689wrn.132.1620738586076; Tue, 11 May 2021 06:09:46 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id b8sm28576544wrx.15.2021.05.11.06.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 06:09:45 -0700 (PDT) Date: Tue, 11 May 2021 15:09:44 +0200 From: Olivier Matz To: David Marchand Cc: dev@dpdk.org, ian.stokes@intel.com, ktraynor@redhat.com, Ranjit Menon , Dmitry Kozlyuk Message-ID: <20210511130944.GI1726@platinum> References: <20210506151426.28202-1-david.marchand@redhat.com> <20210506151426.28202-3-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210506151426.28202-3-david.marchand@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 06, 2021 at 05:14:26PM +0200, David Marchand wrote: > Spotted by sparse in OVS build: > ../../lib/netdev-dpdk.c: note: in included file (through > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...): > ../../include/sparse/arpa/inet.h:22:2: error: "Must include > before for FreeBSD support" > > This is a check enforced by OVS itself. > See [1] for some context. > > 1: https://github.com/openvswitch/ovs/commit/b2befd5bb2db > > Fixes: 89813a522e68 ("net: provide IP-related API on any OS") > > Signed-off-by: David Marchand Acked-by: Olivier Matz