DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: declan.doherty@intel.com, gakhil@marvell.com, aconole@redhat.com,
	hemant.agrawal@nxp.com, anoobj@marvell.com, ruifeng.wang@arm.com,
	asomalap@amd.com, ajit.khaparde@broadcom.com, g.singh@nxp.com,
	roy.fan.zhang@intel.com, Ciara Power <ciara.power@intel.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v4 6/7] test/crypto: fix return value on test skipped
Date: Wed, 12 May 2021 11:36:54 +0000	[thread overview]
Message-ID: <20210512113655.568814-7-ciara.power@intel.com> (raw)
In-Reply-To: <20210512113655.568814-1-ciara.power@intel.com>

The blockcipher testcase return value TEST_SUCCESS was incorrect for
one conditional check, it should have been TEST_SKIPPED similar to the
other condition checks in this function when the testcase is skipped.

Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
Cc: roy.fan.zhang@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test/test_cryptodev_blockcipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
index b99d2ce50a..411968837f 100644
--- a/app/test/test_cryptodev_blockcipher.c
+++ b/app/test/test_cryptodev_blockcipher.c
@@ -170,7 +170,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
 			printf("Raw Data Path APIs do not support OOP, "
 				"Test Skipped.\n");
 			snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED");
-			status = TEST_SUCCESS;
+			status = TEST_SKIPPED;
 			goto error_exit;
 		}
 	}
-- 
2.25.1


  parent reply	other threads:[~2021-05-12 11:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 11:36 [dpdk-dev] [PATCH v4 0/7] test: refactor crypto unit test framework Ciara Power
2021-05-12 11:36 ` [dpdk-dev] [PATCH v4 1/7] app/test: refactor of unit test suite runner Ciara Power
2021-05-12 11:36 ` [dpdk-dev] [PATCH v4 2/7] test: introduce parent testsuite format Ciara Power
2021-05-12 11:36 ` [dpdk-dev] [PATCH v4 3/7] test/crypto: refactor to use sub-testsuites Ciara Power
2021-05-12 11:36 ` [dpdk-dev] [PATCH v4 4/7] test/crypto: replace unsupported with skipped Ciara Power
2021-05-12 11:36 ` [dpdk-dev] [PATCH v4 5/7] test/crypto: move testsuite params to header file Ciara Power
2021-05-12 11:36 ` Ciara Power [this message]
2021-05-12 11:36 ` [dpdk-dev] [PATCH v4 7/7] test/crypto: dynamically build blockcipher suite Ciara Power
2021-05-12 13:15 ` [dpdk-dev] [EXT] [PATCH v4 0/7] test: refactor crypto unit test framework Akhil Goyal
2021-05-12 15:42   ` Thomas Monjalon
2021-05-12 16:00     ` Akhil Goyal
2021-05-12 16:05       ` Thomas Monjalon
2021-05-12 16:06         ` Akhil Goyal
2021-05-13 13:28   ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512113655.568814-7-ciara.power@intel.com \
    --to=ciara.power@intel.com \
    --cc=aconole@redhat.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anoobj@marvell.com \
    --cc=asomalap@amd.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=ruifeng.wang@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).