From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FAB6A0A0C; Thu, 13 May 2021 10:34:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 684E1410FE; Thu, 13 May 2021 10:34:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A6338410FD for ; Thu, 13 May 2021 10:34:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620894883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QZU1T/8rbKPnkEv034RTRWpAP+RzICjU/p+DsEi+mCY=; b=MxFygCo86t9ZnqJ0xetSeVPTKQb+mQ42PRWAuQOx7v0OqOc0cqUQWlFXORhpPtVg+u9iV7 YQIFayB1GclioTIssx9OnFUbTuT5ChLzzah37VbRbUZit7J9dVxWkGurVZNlx4Q3xPn+7i +xCy5NBYumKTGp0GX26mm3kKf04zpS0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-C9zrfKe6Oa2lDsRM-r2O8g-1; Thu, 13 May 2021 04:34:41 -0400 X-MC-Unique: C9zrfKe6Oa2lDsRM-r2O8g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22D2D107ACF3; Thu, 13 May 2021 08:34:40 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDA036E407; Thu, 13 May 2021 08:34:37 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, bruce.richardson@intel.com, mdr@ashroe.eu Date: Thu, 13 May 2021 10:34:14 +0200 Message-Id: <20210513083415.32187-2-david.marchand@redhat.com> In-Reply-To: <20210513083415.32187-1-david.marchand@redhat.com> References: <20210225111457.32540-1-david.marchand@redhat.com> <20210513083415.32187-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v3 2/3] devtools: catch symbol duplicates in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add a check on versioned symbol duplicates in map files. Signed-off-by: David Marchand --- Changes since v1: - rebased, --- devtools/check-symbol-maps.sh | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index 08451ef5aa..8a976dc97f 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -34,4 +34,19 @@ if [ -n "$orphan_symbols" ] ; then ret=1 fi +find_duplicate_symbols () +{ + for map in $(find lib drivers -name '*.map') ; do + buildtools/map-list-symbol.sh $map | \ + sort | uniq -c | grep -v " 1 $map" || true + done +} + +duplicate_symbols=$(find_duplicate_symbols) +if [ -n "$duplicate_symbols" ] ; then + echo "Found duplicates in symbol map file:" + echo "$duplicate_symbols" + ret=1 +fi + exit $ret -- 2.23.0