From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3422DA0A02; Fri, 21 May 2021 11:12:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DCE041102; Fri, 21 May 2021 11:12:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8582841102 for ; Fri, 21 May 2021 11:12:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621588322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0DDyO07A04aQ9L3k0NCMELSNNztaGjJ2/ptEfR/ffs=; b=hARN9TM0nGwWCtVqThl5+5RZBDGzvicNeWtgiWaX9aUtL0DUUjT077KrUZPrON3pVelh00 x8L29LRtjtTeVqdJC6chGTVYrMhnJAnLwCONFO6ow5xo6WcMjxL4TVd+j2Bu6q7O/RIvyw 32IQVo+ViQ10pmvK5dUloy6ouxkfHIw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-4dRPbsLMOMyb3gK2Yt_H8Q-1; Fri, 21 May 2021 05:11:57 -0400 X-MC-Unique: 4dRPbsLMOMyb3gK2Yt_H8Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE214101371F; Fri, 21 May 2021 09:11:56 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20D30189B6; Fri, 21 May 2021 09:11:54 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, jerinj@marvell.com, timothy.mcdaniel@intel.com, stable@dpdk.org Date: Fri, 21 May 2021 11:11:34 +0200 Message-Id: <20210521091137.21221-2-david.marchand@redhat.com> In-Reply-To: <20210521091137.21221-1-david.marchand@redhat.com> References: <20210521091137.21221-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v3 1/4] event/dlb2: remove references to deferred scheduling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Timothy McDaniel Deferred scheduling is a DLB v1.0 feature, and is not valid for DLB v2.0 or v2.5. Fixes: bc62748bd7d4 ("event/dlb2: add private data structures and constants") Fixes: a2e4f1f5e79f ("event/dlb2: add dequeue and its burst variants") Cc: stable@dpdk.org Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 21 --------------------- drivers/event/dlb2/dlb2_priv.h | 3 --- 2 files changed, 24 deletions(-) diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rst index 31de6bc470..c60c454d6b 100644 --- a/doc/guides/eventdevs/dlb2.rst +++ b/doc/guides/eventdevs/dlb2.rst @@ -293,27 +293,6 @@ The PMD does not support the following configuration sequences: This sequence is not supported because the event device must be reconfigured before its ports or queues can be. -Deferred Scheduling -~~~~~~~~~~~~~~~~~~~ - -The DLB PMD's default behavior for managing a CQ is to "pop" the CQ once per -dequeued event before returning from rte_event_dequeue_burst(). This frees the -corresponding entries in the CQ, which enables the DLB to schedule more events -to it. - -To support applications seeking finer-grained scheduling control -- for example -deferring scheduling to get the best possible priority scheduling and -load-balancing -- the PMD supports a deferred scheduling mode. In this mode, -the CQ entry is not popped until the *subsequent* rte_event_dequeue_burst() -call. This mode only applies to load-balanced event ports with dequeue depth of -1. - -To enable deferred scheduling, use the defer_sched vdev argument like so: - - .. code-block:: console - - --vdev=dlb2_event,defer_sched=on - Atomic Inflights Allocation ~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h index 3140764a59..b1225af37e 100644 --- a/drivers/event/dlb2/dlb2_priv.h +++ b/drivers/event/dlb2/dlb2_priv.h @@ -32,7 +32,6 @@ #define DLB2_MAX_NUM_EVENTS "max_num_events" #define DLB2_NUM_DIR_CREDITS "num_dir_credits" #define DEV_ID_ARG "dev_id" -#define DLB2_DEFER_SCHED_ARG "defer_sched" #define DLB2_QID_DEPTH_THRESH_ARG "qid_depth_thresh" #define DLB2_COS_ARG "cos" #define DLB2_POLL_INTERVAL_ARG "poll_interval" @@ -585,7 +584,6 @@ struct dlb2_eventdev { uint16_t num_dir_ports; /* total num of dir ports requested */ bool umwait_allowed; bool global_dequeue_wait; /* Not using per dequeue wait if true */ - bool defer_sched; enum dlb2_cq_poll_modes poll_mode; int poll_interval; int sw_credit_quanta; @@ -620,7 +618,6 @@ struct dlb2_devargs { int max_num_events; int num_dir_credits_override; int dev_id; - int defer_sched; struct dlb2_qid_depth_thresholds qid_depth_thresholds; enum dlb2_cos cos_id; int poll_interval; -- 2.23.0