From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3920A0A02; Fri, 21 May 2021 11:12:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABCB341114; Fri, 21 May 2021 11:12:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id E9CD541107 for ; Fri, 21 May 2021 11:12:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621588336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y1YlhIRANgbNNXUzL6K6PCrThZC7kln25hr16phcrKs=; b=YC0SD1axLATRYm59WjvnAc+XGegQ3eI/Ys5y2DdQ2fIrC7SLnGWvz05xz3p33nRcokBGzH msoyzQW8bzOcU/29nDWSmvmHf0LXpmLoskgoTi/wbrhDX1iX691h+xGHbFfmbxqboFmJMl /yiim8SACQRbAvqTQQBmGSSyAiWFuP4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-p-NzBp64PUy3av3uqAnoyw-1; Fri, 21 May 2021 05:12:14 -0400 X-MC-Unique: p-NzBp64PUy3av3uqAnoyw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D60AF80ED8B; Fri, 21 May 2021 09:12:12 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16BF5189B6; Fri, 21 May 2021 09:12:10 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, jerinj@marvell.com, timothy.mcdaniel@intel.com Date: Fri, 21 May 2021 11:11:37 +0200 Message-Id: <20210521091137.21221-5-david.marchand@redhat.com> In-Reply-To: <20210521091137.21221-1-david.marchand@redhat.com> References: <20210521091137.21221-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v3 4/4] event/dlb2: select scalar dequeue by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Timothy McDaniel Optimized dequeue using x86 vector instructions was added in 21.05, but due to limited testing the default has been changed back to the scalar mode implementation. The vector mode implementation can be enabled via the devargs option "vector_opts_enabled=". Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation") Signed-off-by: Timothy McDaniel Signed-off-by: David Marchand --- Changes since v2: - updated title, - rebased with doc patch, --- doc/guides/eventdevs/dlb2.rst | 13 +++++++++++++ drivers/event/dlb2/dlb2.c | 24 ++++++++++++------------ drivers/event/dlb2/dlb2_priv.h | 6 +++--- 3 files changed, 28 insertions(+), 15 deletions(-) diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rst index 99ea8418a5..bce984ca08 100644 --- a/doc/guides/eventdevs/dlb2.rst +++ b/doc/guides/eventdevs/dlb2.rst @@ -367,3 +367,16 @@ Class of service can be specified in the devargs, as follows .. code-block:: console --allow ea:00.0,cos=<0..4> + +Use X86 Vector Instructions +~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +DLB supports using x86 vector instructions to optimize the data path. + +The default mode of operation is to use scalar instructions, but +the use of vector instructions can be enabled in the devargs, as +follows + + .. code-block:: console + + --allow ea:00.0,vector_opts_enabled= diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 2a3e4ddb47..eca183753f 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -376,11 +376,11 @@ set_default_depth_thresh(const char *key __rte_unused, } static int -set_vector_opts_disab(const char *key __rte_unused, +set_vector_opts_enab(const char *key __rte_unused, const char *value, void *opaque) { - bool *dlb2_vector_opts_disabled = opaque; + bool *dlb2_vector_opts_enabled = opaque; if (value == NULL || opaque == NULL) { DLB2_LOG_ERR("NULL pointer\n"); @@ -388,9 +388,9 @@ set_vector_opts_disab(const char *key __rte_unused, } if ((*value == 'y') || (*value == 'Y')) - *dlb2_vector_opts_disabled = true; + *dlb2_vector_opts_enabled = true; else - *dlb2_vector_opts_disabled = false; + *dlb2_vector_opts_enabled = false; return 0; } @@ -1469,7 +1469,7 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2, #else if ((qm_port->cq_depth > 64) || (!rte_is_power_of_2(qm_port->cq_depth)) || - (dlb2->vector_opts_disabled == true)) + (dlb2->vector_opts_enabled == false)) qm_port->use_scalar = true; #endif @@ -1665,7 +1665,7 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2, #else if ((qm_port->cq_depth > 64) || (!rte_is_power_of_2(qm_port->cq_depth)) || - (dlb2->vector_opts_disabled == true)) + (dlb2->vector_opts_enabled == false)) qm_port->use_scalar = true; #endif @@ -4434,7 +4434,7 @@ dlb2_primary_eventdev_probe(struct rte_eventdev *dev, dlb2->poll_interval = dlb2_args->poll_interval; dlb2->sw_credit_quanta = dlb2_args->sw_credit_quanta; dlb2->default_depth_thresh = dlb2_args->default_depth_thresh; - dlb2->vector_opts_disabled = dlb2_args->vector_opts_disabled; + dlb2->vector_opts_enabled = dlb2_args->vector_opts_enabled; err = dlb2_iface_open(&dlb2->qm_instance, name); if (err < 0) { @@ -4538,7 +4538,7 @@ dlb2_parse_params(const char *params, DLB2_POLL_INTERVAL_ARG, DLB2_SW_CREDIT_QUANTA_ARG, DLB2_DEPTH_THRESH_ARG, - DLB2_VECTOR_OPTS_DISAB_ARG, + DLB2_VECTOR_OPTS_ENAB_ARG, NULL }; if (params != NULL && params[0] != '\0') { @@ -4653,11 +4653,11 @@ dlb2_parse_params(const char *params, } ret = rte_kvargs_process(kvlist, - DLB2_VECTOR_OPTS_DISAB_ARG, - set_vector_opts_disab, - &dlb2_args->vector_opts_disabled); + DLB2_VECTOR_OPTS_ENAB_ARG, + set_vector_opts_enab, + &dlb2_args->vector_opts_enabled); if (ret != 0) { - DLB2_LOG_ERR("%s: Error parsing vector opts disabled", + DLB2_LOG_ERR("%s: Error parsing vector opts enabled", name); rte_kvargs_free(kvlist); return ret; diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h index b1225af37e..bb87072da0 100644 --- a/drivers/event/dlb2/dlb2_priv.h +++ b/drivers/event/dlb2/dlb2_priv.h @@ -37,7 +37,7 @@ #define DLB2_POLL_INTERVAL_ARG "poll_interval" #define DLB2_SW_CREDIT_QUANTA_ARG "sw_credit_quanta" #define DLB2_DEPTH_THRESH_ARG "default_depth_thresh" -#define DLB2_VECTOR_OPTS_DISAB_ARG "vector_opts_disable" +#define DLB2_VECTOR_OPTS_ENAB_ARG "vector_opts_enable" /* Begin HW related defines and structs */ @@ -565,7 +565,7 @@ struct dlb2_eventdev { uint32_t new_event_limit; int max_num_events_override; int num_dir_credits_override; - bool vector_opts_disabled; + bool vector_opts_enabled; volatile enum dlb2_run_state run_state; uint16_t num_dir_queues; /* total num of evdev dir queues requested */ union { @@ -623,7 +623,7 @@ struct dlb2_devargs { int poll_interval; int sw_credit_quanta; int default_depth_thresh; - bool vector_opts_disabled; + bool vector_opts_enabled; }; /* End Eventdev related defines and structs */ -- 2.23.0