DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: do not use a possibly NULL Pointer
@ 2021-05-24  9:01 Thierry Herbelot
  2021-05-25 14:01 ` Bing Zhao
  2021-06-10 17:28 ` Singh, Aman Deep
  0 siblings, 2 replies; 4+ messages in thread
From: Thierry Herbelot @ 2021-05-24  9:01 UTC (permalink / raw)
  To: dev; +Cc: Thierry Herbelot, Thomas Monjalon, stable, Ori Kam

Use out only after it was checked not to be NULL.

Fixes: 4d07cbefe3ba0 ("app/testpmd: add commands for conntrack")
Cc: stable@dpdk.org
Cc: Ori Kam <orika@nvidia.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1c587bb7b803..7645b3cc90a1 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -6631,10 +6631,10 @@ parse_vc_action_conntrack_update(struct context *ctx, const struct token *token,
 	/* Token name must match. */
 	if (parse_default(ctx, token, str, len, NULL, 0) < 0)
 		return -1;
-	ct_modify = (struct rte_flow_modify_conntrack *)out->args.vc.data;
 	/* Nothing else to do if there is no buffer. */
 	if (!out)
 		return len;
+	ct_modify = (struct rte_flow_modify_conntrack *)out->args.vc.data;
 	if (ctx->curr == ACTION_CONNTRACK_UPDATE_DIR) {
 		ct_modify->new_ct.is_original_dir =
 				conntrack_context.is_original_dir;
-- 
2.29.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-29  8:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24  9:01 [dpdk-dev] [PATCH] app/testpmd: do not use a possibly NULL Pointer Thierry Herbelot
2021-05-25 14:01 ` Bing Zhao
2021-06-10 17:28 ` Singh, Aman Deep
2021-06-29  8:26   ` Andrew Rybchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).