From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF05AA0546; Tue, 25 May 2021 19:14:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D64D40150; Tue, 25 May 2021 19:14:39 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2046.outbound.protection.outlook.com [40.107.102.46]) by mails.dpdk.org (Postfix) with ESMTP id 96D0F4003F; Tue, 25 May 2021 19:14:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InVref9NWn8yQJNrgi4hD0kJ9AvduMFxS7TX+vhtA44DPCJIwY0ZAsIepngI43202NVaRuNdpAziTLAHikXmm39A5YoOrX1Sq4B+ksmjTRSWLuwmf4LUj0LWQgGDaAiT+wrT9d34phVQ1vkG98wf+qFwxZvgZR7RmgajphdWMdgVDFGVTKvlPYMtkDdsc4LTdrpuFwq8O96G4yMlKcRb0Vo7q/XDmBbU1x8VOTxK0PkVKbXPDpQUzoKLD9X1XlScKNHSyiTgpyO86zX4QoUemIMx4am26QHAic42ow0iwtnRVNVHWIuAT2dW/9hqbv+OCVmgmyThe6/OkT9UiTPiZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNlk0F7EHnDHvoxt3tZ/bplq1WKksJiZgVy4fJVbw5U=; b=igJnhuzCVXs9G8N3AKcCkXwQItdpd6qTP3lYEoD5aF/vIMhzY9GWoahbAg5I2ffmuts6GKBRW7wHbpa+el4qkhbDEwiQX/CpNHW0fsLkE06VSRIXif/bEcVbsG53TaZ7wf4nqtukDaLCnOjh3MZC0cTeupOSsTCuB47zWN9R2QxncWtWQWXL2q4B/Cyaao/P77P3vC5ssE4yeoIQqDwFNNvXWxYpSPS1nQqGTq282Uz1yqcU5fZhU9Nw4bBJFwl0Jtx6w9uPr8rynSfbOd/oI6XN21eA8TyE4f4dS4Jtev9xRRDyu2ky+vmDnYES1H7ttnsuOAEZjtOeyB9o6E7Abw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNlk0F7EHnDHvoxt3tZ/bplq1WKksJiZgVy4fJVbw5U=; b=Xb9KqEWD4VCAxlJlBznkhw5+oROeObE7ONVolu4cB9tCn2f+GDtBWOFO5flAHaU3Rc05FA4eN9tOc594gZZWgaSnFaFqEeAgG51obAj1MV+FbQze5cUHNUKU1XClniUJLRKFVs4t8TtOC00+rYll0kbkMbqfNvnRCo7hGN15tQa6hh/ua3P9GIB3dnmpvHYMOiACRKidaq3CtFaeQEZFzFctXg7tjNMsNG2sLinivMhprmRZNKVEXkYLqGsuUbJpYsmoFibIsWzIPJABH+nN24RnfKev0uL1IYOI4RYWK8jQIZazo72qrLAuvgWnfTkYpLUUrJeGdC0fAbEB+cQ4ig== Received: from MW2PR16CA0049.namprd16.prod.outlook.com (2603:10b6:907:1::26) by MN2PR12MB3134.namprd12.prod.outlook.com (2603:10b6:208:c5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Tue, 25 May 2021 17:14:36 +0000 Received: from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::fa) by MW2PR16CA0049.outlook.office365.com (2603:10b6:907:1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Tue, 25 May 2021 17:14:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 25 May 2021 17:14:35 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 25 May 2021 17:14:29 +0000 From: Alexander Kozyrev To: CC: , , , , Date: Tue, 25 May 2021 20:14:14 +0300 Message-ID: <20210525171414.1155872-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4397802c-34bf-4310-180b-08d91fa0921b X-MS-TrafficTypeDiagnostic: MN2PR12MB3134: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZRYR5Og8M2azNb3THOnEJrcp6aRVtaCzzv0Hg3hbnsU/3N5WdVU8DsY2N1mtrf5JGGVxf9Apy39TIx7UV0QTZINp61o8vADfN9Z/neLfLzIT7WAWPyUYgzP9Hl9U9qxJkMU/G5AkD//SUi9FpwAfDNIJEkRX1QqCVTpqfNHtyI1ZJpW3/dVmu+owHsAVzpeCnQwd3+sq5bIzwpWgZ0+SsBe/igLQeDNrMU9kwWbZpxnF+5cFst1GYRFIdyXbBHegJxgW+NTGsPR0EdtvWSDf4anS23FmeQMN22c4SYwl33z+GZ45EMOFrCGSnMJ/zkqzLF+KxB1dXIvY45HioigsH8+6dz7nqnX8IiOzTgspta2HyX69Ybkw8trR3SKekf4bO+MApnJuCJYMBL6WM31GbHyp7/k3Id9UbWuDE6UHr/UkjHPVrY+719K/TFfKL0NmHODq3OMor9yfEGe/xnSqI8y8t0bkZwSMQVg1TKR0K4IsXaC6x1nPof1jeJNbmzxjfccw+VseYbbY18f3T/Ey103cPvulsJFD3jKblNrSX9HAy0t7N5SW0gUFU3xO//PBRyZSKLoMaHi/3WBPJjRo7OWvfBsNNB6+UoHGISNVYw0nvYyHnZoOpBdlwlKQ/KlrRLkj46jKP6stVMA6BWfIspH3VGgNoPvLeO+ezpgBmX8= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(346002)(39850400004)(36840700001)(46966006)(83380400001)(336012)(70206006)(478600001)(6286002)(54906003)(6916009)(356005)(16526019)(7696005)(7636003)(107886003)(70586007)(2616005)(426003)(82310400003)(26005)(6666004)(5660300002)(36860700001)(2906002)(4326008)(316002)(36756003)(450100002)(86362001)(55016002)(1076003)(8676002)(82740400003)(47076005)(186003)(36906005)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 17:14:35.4694 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4397802c-34bf-4310-180b-08d91fa0921b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3134 Subject: [dpdk-dev] [PATCH] net/mlx5: allow copy from one tag to another X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The modify field implementation in mlx5 driver has a check to prevent a copy from a field to the same field. But the level is not taken into account which prevents a copy from different tags. Check the level and allow a copy from one tag to another. Fixes: 641dbe4fb05 ("net/mlx5: support modify field flow action") Cc: stable@dpdk.org Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index c50649a107..acb9af4e61 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -4788,8 +4788,10 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev, "inner header fields modification" " is not supported"); } - if (action_modify_field->dst.field == - action_modify_field->src.field) + if ((action_modify_field->dst.field == + action_modify_field->src.field) && + (action_modify_field->dst.level == + action_modify_field->src.level)) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, action, "source and destination fields" -- 2.18.2