From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C404A0547; Fri, 28 May 2021 19:33:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C0B340143; Fri, 28 May 2021 19:33:11 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id DCBD140040; Fri, 28 May 2021 19:33:09 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id 1D52A20B7188; Fri, 28 May 2021 10:33:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1D52A20B7188 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1622223189; bh=cZp6ertaOXvzNA0VpMN3Uq8QnAPBwr8G4I6b3xnC5tM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=crVFOjb9XkPCbTpYXaoAOSaGDqlT6j7RGONhOwtWMPUS0JoKZKmL8ukagmyQWh1Ek AVDxNjOOoSi8S8FrizIbUthHxrOQqhAPdKtEURjTfnUeq+WmiRhGHtCVNy09pEdlbV mA+thL0+SIJbhzad3LbtRHPpQc6tKAibzSjubqBg= Date: Fri, 28 May 2021 10:33:09 -0700 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Harman Kalra Message-ID: <20210528173309.GA3572@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210502023333.30351-1-dmitry.kozliuk@gmail.com> <20210502023333.30351-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210502023333.30351-3-dmitry.kozliuk@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH 3/3] eal/windows: cleanup interrupt resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, May 02, 2021 at 05:33:33AM +0300, Dmitry Kozlyuk wrote: > Interrupt manager in Windows EAL allocates on IOCP and starts > a control thread that runs indefinitely. At DPDK cleanup > this thread was not stopped and IOCP handle was not closed. > > Gracefully stop interrupt-handling in rte_eal_cleanup(). > The thread already closes IOCP handle before exiting. > > Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk Acked-by: Jie Zhou Tested-by: Jie Zhou > --- > lib/eal/windows/eal.c | 1 + > lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++-- > lib/eal/windows/eal_windows.h | 5 +++++ > 3 files changed, 30 insertions(+), 2 deletions(-) Enabled a subset of Unit test on Windows and when running alarm_autotest, system hang at rte_eal_alarm_set. After applying this patch set, no repro any more. Also system hang at pmd_perf_autotest and no repro with the patch. It is with Intel i40e.